Review main Merged

6889[FEATURE] Add a rel="nofollow" on the "Forgot your password" link

Dmitry Dulepov CR +2 V +2 Easy +1 −0 updated 06/03/13, 20:49

Commit message

There is no reason for search engines to crawl the "Forgot your
password?" page. Add a rel="nofollow" in the felogin to advice
search engines not to crawl the page.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Mario Rimann +1
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2
    • Steffen Ritter +2
    • Simon Schaufelberger +1

Issues 1

Files 1

Review log 14

  1. Dmitry Dulepov uploaded patch set 2 11/25/11, 09:02

  2. Dmitry Dulepov uploaded patch set 3 11/25/11, 09:02

  3. Mario Rimann commented on patch set 4 11/25/11, 09:02

    Looks good to me, but someone else must approve
  4. Dmitry Dulepov uploaded patch set 4 11/25/11, 09:02

  5. Georg Ringer commented on patch set 1 11/25/11, 09:02

    I would prefer that you didn't submit this
    the rel-tag doesn't really prevent the search engine to crawl the page, so I would prefer a different text like "advice search engines to not crawl the page"

    ext_typoscript_setup.txt:20

    missing "

    ext_typoscript_setup.txt:20

    still a " missing
  6. Georg Ringer commented on patch set 2 1 comment 11/25/11, 09:02

    I would prefer that you didn't submit this
  7. Georg Ringer commented on patch set 4 11/25/11, 09:02

    Looks good to me, but someone else must approve
  8. Steffen Ritter commented on patch set 4 V 0 11/25/11, 09:02

    by team member; Looks good to me, approved
  9. Simon Schaufelberger commented on patch set 4 11/25/11, 09:02

    Verified; Looks good to me, but someone else must approve
  10. Mr. Jenkins commented on patch set 1 11/25/11, 09:02

  11. Mr. Jenkins commented on patch set 2 11/25/11, 09:02

  12. Mr. Jenkins commented on patch set 3 11/25/11, 09:02

  13. Mr. Jenkins commented on patch set 4 11/25/11, 09:02

  14. Steffen Ritter merged patch set 4 11/25/11, 09:02