Review main Merged

68890[TASK] Center text in infobox vertically

Nikita Hovratov CR +2 V +2 Easy +2 −10 updated 05/04/21, 19:38

Commit message

In case an infobox has an icon but no title and the text is just one
line, the text is now vertically centered.

Also remove the css property "vertical-align: middle" as it has no
effect anymore.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1520

  1. Nikita Hovratov uploaded patch set 1 04/27/21, 18:54

  2. core-ci voted on patch set 1 V +1 04/27/21, 19:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10769

  3. Oli Bartsch updated the commit message in patch set 2 04/27/21, 19:39

  4. Oli Bartsch commented on patch set 2 04/27/21, 19:44

    _callout.scss:94

    A quick search revealed two more places where .media-body has `vertial-align: middle` assigned. Should we also adjust those?
  5. Nikita Hovratov commented on patch set 2 04/27/21, 19:48

    _callout.scss:94 Reply

    Probably yes, I can have a quick look if it's really not needed.
  6. core-ci voted on patch set 2 V +1 04/27/21, 19:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10777

  7. Oli Bartsch commented on patch set 2 04/27/21, 19:50

    _callout.scss:94 Reply

    That would be great.
  8. Nikita Hovratov uploaded patch set 3 04/27/21, 20:16

  9. Nikita Hovratov commented on patch set 3 04/27/21, 20:25

    _callout.scss:94 Reply Unresolved

    The last one in errorpage.css was still needed. It would be nice to extract the .media component and include it there. Also there exists now an _alert.scss component and _element_messages, which both style .alert class. I guess this can be combined.
  10. core-ci voted on patch set 3 V +1 04/27/21, 20:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10783

  11. Nikita Hovratov uploaded patch set 4 05/03/21, 17:39

  12. core-ci voted on patch set 4 V +1 05/03/21, 17:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11061

  13. Riccardo De Contardi commented on patch set 4 V +1 05/03/21, 19:40

  14. Oli Bartsch uploaded patch set 5 05/04/21, 19:25

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 05/04/21, 19:27

  16. Andreas Kienast voted on patch set 5 V +1 CR +1 05/04/21, 19:28

  17. Oliver Hader voted on patch set 5 CR +1 05/04/21, 19:30

  18. Andreas Kienast voted on patch set 5 V +2 CR +2 05/04/21, 19:30

  19. core-ci voted on patch set 5 V +1 05/04/21, 19:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11158

  20. Andreas Kienast merged patch set 6 05/04/21, 19:38