68890[TASK] Center text in infobox vertically
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Oliver Hader +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1520
-
Nikita Hovratov uploaded patch set 1 04/27/21, 18:54
-
core-ci voted on patch set 1 V +1 04/27/21, 19:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10769
-
Oli Bartsch updated the commit message in patch set 2 04/27/21, 19:39
-
Oli Bartsch commented on patch set 2 04/27/21, 19:44
-
Nikita Hovratov commented on patch set 2 04/27/21, 19:48
_callout.scss:94ReplyProbably yes, I can have a quick look if it's really not needed. -
core-ci voted on patch set 2 V +1 04/27/21, 19:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10777
-
Oli Bartsch commented on patch set 2 04/27/21, 19:50
_callout.scss:94ReplyThat would be great. -
Nikita Hovratov uploaded patch set 3 04/27/21, 20:16
-
Nikita Hovratov commented on patch set 3 04/27/21, 20:25
_callout.scss:94Reply UnresolvedThe last one in errorpage.css was still needed. It would be nice to extract the .media component and include it there. Also there exists now an _alert.scss component and _element_messages, which both style .alert class. I guess this can be combined. -
core-ci voted on patch set 3 V +1 04/27/21, 20:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10783
-
Nikita Hovratov uploaded patch set 4 05/03/21, 17:39
-
core-ci voted on patch set 4 V +1 05/03/21, 17:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11061
-
Riccardo De Contardi commented on patch set 4 V +1 05/03/21, 19:40
tested against https://forge.typo3.org/issues/93181 https://forge.typo3.org/issues/93998 both solved -
Oli Bartsch uploaded patch set 5 05/04/21, 19:25
-
Oli Bartsch voted on patch set 5 V +1 CR +1 05/04/21, 19:27
-
Andreas Kienast voted on patch set 5 V +1 CR +1 05/04/21, 19:28
-
Oliver Hader voted on patch set 5 CR +1 05/04/21, 19:30
-
Andreas Kienast voted on patch set 5 V +2 CR +2 05/04/21, 19:30
-
core-ci voted on patch set 5 V +1 05/04/21, 19:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11158
-
Andreas Kienast merged patch set 6 05/04/21, 19:38
_callout.scss:94