Review main Merged

68891[BUGFIX] Avoid text/javascript for HTML doctypes

Oli Bartsch CR +2 V +2 Easy +15 −10 updated 04/27/21, 21:42

Commit message

The PageRenderer `inlineJavaScriptWrap`, used for
wrapping general JavaScript such as spam protection,
is adjusted to remove the  "text/javascript" type in case
the the doctype is not XHTML.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1115

  1. Oli Bartsch uploaded patch set 1 04/27/21, 18:57

  2. Benni Mack commented on patch set 1 04/27/21, 18:58

    PageRenderer.php:470 Unresolved

    you also have to take in the $enable case.
  3. Oli Bartsch uploaded patch set 2 04/27/21, 19:00

  4. Oli Bartsch uploaded patch set 3 04/27/21, 19:11

  5. core-ci voted on patch set 1 V +1 04/27/21, 19:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10770

  6. Benni Mack voted on patch set 3 CR +1 04/27/21, 19:13

  7. core-ci voted on patch set 2 V +1 04/27/21, 19:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10771

  8. core-ci voted on patch set 3 V +1 04/27/21, 19:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10772

  9. Benni Mack voted on patch set 3 V +1 04/27/21, 20:18

  10. Oli Bartsch uploaded patch set 4 04/27/21, 20:33

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 04/27/21, 20:36

  12. core-ci voted on patch set 4 V +1 04/27/21, 20:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10788

  13. Benni Mack voted on patch set 4 V +1 CR +1 04/27/21, 21:34

  14. Oli Bartsch voted on patch set 4 V +2 CR +2 04/27/21, 21:42

  15. Oli Bartsch merged patch set 5 04/27/21, 21:42