Review main Merged

68894[BUGFIX] Remove superfluous data attributes in ElementBrowser/LinkPicker

Benni Mack CR +2 V +2 Normal +8 −80 updated 04/28/21, 08:51

Commit message

Various logic can be simplified within the ElementBrowser / LinkPicker
code base, where unused properties are handed around JS / PHP
without any usages anymore, due to previous refactorings.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 57

  1. Benni Mack uploaded patch set 1 04/27/21, 20:16

  2. core-ci voted on patch set 1 V +1 04/27/21, 20:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10782

  3. Benni Mack uploaded patch set 2 04/27/21, 20:44

  4. core-ci voted on patch set 2 V +1 04/27/21, 20:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10789

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 04/27/21, 21:13

  6. Oli Bartsch voted on patch set 2 V +2 CR +2 04/28/21, 08:51

  7. Oli Bartsch merged patch set 3 04/28/21, 08:51