Review 10.4 Merged

68895[TASK] Introduce composer manifest checks

Oliver Hader CR +2 V +2 Hard +775 −2 updated 05/01/21, 13:48

Commit message

The extension manager now provides a new module,
which allows an integrator to display all available
extensions with composer deficits, like missing
composer.json or missing extension-key.

The new module informs about the deficit and
automatically generates a valid composer.json.
proposal. In case no composer.json exists, the
corresponding ext_emconf is sent to a new TER
endpoint (https://extensions.typo3.org/composerize).
This endpoint then generates a new composer.json
proposal by resolving all dependencies.

Furthermore, a new report is added to EXT:reports
which also informs about such extensions by directly
linking to the new EM module.

This helps especially in non-composer-mode installations
to ease the upgrade path for future TYPO3 versions which
(hopefully) will rely on composer.json only for e.g.
PackageStates.php.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 13

Review log 69

  1. Oliver Hader uploaded patch set 1 04/27/21, 21:20

  2. Oliver Hader commented on patch set 1 CR -1 04/27/21, 21:20

    Wait for master patch...
  3. core-ci voted on patch set 1 V -1 04/27/21, 21:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10797

  4. Oli Bartsch uploaded patch set 2 04/28/21, 20:29

  5. core-ci voted on patch set 2 V +1 04/28/21, 20:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10849

  6. Oli Bartsch rebased onto patch set 3 05/01/21, 13:35

  7. core-ci voted on patch set 3 V +1 05/01/21, 13:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11012

  8. Oli Bartsch voted on patch set 3 V +2 CR +2 05/01/21, 13:48

  9. Oli Bartsch merged patch set 4 05/01/21, 13:48