Review 9.5 Merged

68897[BUGFIX] Avoid exception when trying to download a non-existing file

Oliver Hader CR +2 V +2 Easy +2 −8 updated 05/04/21, 13:19

Commit message

This patch fixes a regression introduced by change
https://review.typo3.org/c/Packages/TYPO3.CMS/+/65126 which lead to
an HTTP 500 exception instead of returning HTTP 404 by making sure
that FileDumpController->isFileValid() is not called with NULL as
parameter.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stephan Großberndt +1
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Oliver Hader uploaded patch set 1 04/27/21, 21:59

  2. core-ci voted on patch set 1 V +1 04/27/21, 22:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10805

  3. Stephan Großberndt voted on patch set 1 CR +1 04/28/21, 07:15

  4. Oliver Hader voted on patch set 1 V +2 CR +2 05/04/21, 13:19

  5. Oliver Hader merged patch set 2 05/04/21, 13:19