Review main Merged

68899[BUGFIX] Properly trigger `change` event in LinkBrowser

Andreas Kienast CR +2 V +2 Easy +2 −5 updated 04/28/21, 08:29

Commit message

With #93975 the LinkBrowser was not able to write back a selected page to
FormEngine. The reason is that the input field has no `onchange`
attribute anymore, thus its event handlers cannot get processed.

The `change` event is now dispatched properly to trigger both, event
listeners and "old-school" onchange handlers.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 04/28/21, 05:49

  2. core-ci voted on patch set 1 V +1 04/28/21, 06:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10819

  3. Benni Mack voted on patch set 1 CR +1 04/28/21, 07:20

  4. Oli Bartsch commented on patch set 1 V +1 CR +1 04/28/21, 08:27

    Thanks for the fix.
  5. Benni Mack voted on patch set 1 V +2 CR +2 04/28/21, 08:29

  6. Benni Mack merged patch set 2 04/28/21, 08:29