Review main Merged

68900[BUGFIX] Use proper implementation class for PagePositionMap

Benni Mack CR +2 V +2 Easy +1 −1 updated 04/29/21, 14:22

Commit message

The PagePositionMap uses the ElementBrowserPageTreeView
which is a specific implementation for the Element Browser (now unused).

However, the PageTreeView is the correct implementation,
as this is also used in all subclasses of PagePositionMap,
handling links properly for moving records or creating new records / pages.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 04/28/21, 10:00

  2. core-ci voted on patch set 1 V +1 04/28/21, 10:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10828

  3. Daniel Goerz voted on patch set 1 V +1 CR +1 04/29/21, 14:20

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 04/29/21, 14:22

  5. Oli Bartsch merged patch set 2 04/29/21, 14:22