Review main Merged

68901[TASK] Simplify hierarchy logic within AbstractTreeView subclasses

Benni Mack CR +2 V +2 Normal +59 −113 updated 04/28/21, 23:21

Commit message

This change simplifies the ExportPageTreeView to extend
from AbstractTreeView directly, making the intermediate subclassing
to BrowseTreeView obsolete.

In addition, several properties which are only used within
ExportPageTreeView are moved into this class, reducing the
actual logic within AbstractTreeView.

Unused properties such as "MOUNTS", "bank" and "stored" are
moved to the respective usage'd subclasses.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Benni Mack uploaded patch set 1 04/28/21, 10:41

  2. core-ci voted on patch set 1 V +1 04/28/21, 10:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10829

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 04/28/21, 20:10

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 04/28/21, 22:49

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 04/28/21, 23:21

  6. Christian Kuhn merged patch set 2 04/28/21, 23:21