Review main Merged

68902[TASK] Remove unused properties from EditDocumentController

Christian Kuhn CR +2 V +2 Normal +44 −92 updated 05/01/21, 17:44

Commit message

The values "_serialNumber", "_scrollPosition", "viewId_addParams"
are hidden form fields that are relics from TYPO3 Core v3.x,
long unused and obsolete.

Same goes for "uc" which just parks an incoming value (where
the FormEngineUtility::updateInlineView() can also be moved
inside the EditDocumentController), and unused values such as
"newC".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1521

  1. Christian Kuhn uploaded patch set 1 04/28/21, 20:36

  2. Christian Kuhn uploaded patch set 2 04/28/21, 20:36

  3. core-ci voted on patch set 1 V -1 04/28/21, 20:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10850

  4. core-ci voted on patch set 2 V +1 04/28/21, 20:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10851

  5. Benni Mack uploaded patch set 3 04/28/21, 21:13

  6. Benni Mack uploaded patch set 4 04/28/21, 21:14

  7. Benni Mack updated the commit message in patch set 5 04/28/21, 21:25

  8. Benni Mack updated the commit message in patch set 6 04/28/21, 21:27

  9. Christian Kuhn rebased onto patch set 7 04/28/21, 22:27

  10. core-ci voted on patch set 7 V -1 04/28/21, 22:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10863

  11. Christian Kuhn rebased onto patch set 8 04/28/21, 22:43

  12. Christian Kuhn rebased onto patch set 9 04/29/21, 08:43

  13. core-ci voted on patch set 9 V -1 04/29/21, 08:56 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10880

  14. Benni Mack rebased onto patch set 10 04/29/21, 18:28

  15. core-ci voted on patch set 10 V -1 04/29/21, 18:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10931

  16. Benni Mack uploaded patch set 11 05/01/21, 12:01

  17. core-ci voted on patch set 11 V +1 05/01/21, 12:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11006

  18. Benni Mack voted on patch set 11 V +1 CR +1 05/01/21, 12:16

  19. Jochen Roth voted on patch set 11 V +1 CR +1 05/01/21, 17:39

  20. Christian Kuhn voted on patch set 11 V +2 CR +2 05/01/21, 17:44

  21. Christian Kuhn merged patch set 12 05/01/21, 17:44