Review main Merged

68904[BUGFIX] Do not download artifacts in gitlab voting stage

Christian Kuhn CR +2 V +2 Easy +4 −0 updated 04/28/21, 23:27

Commit message

By default, gitlab passes all artifacts from previous
stages to each job. Thus, the negative-vote job was not
executed in case previous jobs with artifacts failed.

Since those jobs don't need artifacts anyways, not
downloading them solves the issue.

See: https://docs.gitlab.com/ee/ci/yaml/README.html#dependencies

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1016

  1. Christian Kuhn uploaded patch set 1 04/28/21, 22:02

  2. core-ci voted on patch set 1 V -1 04/28/21, 22:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10860

  3. Christian Kuhn uploaded patch set 2 04/28/21, 22:14

  4. core-ci voted on patch set 2 V -1 04/28/21, 22:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10861

  5. Christian Kuhn uploaded patch set 3 04/28/21, 22:27

  6. core-ci voted on patch set 3 V +1 04/28/21, 22:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10862

  7. Christian Kuhn updated the commit message in patch set 4 04/28/21, 22:58

  8. Christian Kuhn updated the commit message in patch set 5 04/28/21, 23:00

  9. core-ci voted on patch set 4 V +1 04/28/21, 23:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10865

  10. core-ci voted on patch set 5 V +1 04/28/21, 23:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10867

  11. Oli Bartsch updated the commit message in patch set 6 04/28/21, 23:15

  12. Oli Bartsch voted on patch set 6 V +1 CR +1 04/28/21, 23:15

  13. core-ci voted on patch set 6 V +1 04/28/21, 23:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10868

  14. Christian Kuhn commented on patch set 6 04/28/21, 23:25

    i'll take the freedom to merge that pretty much directly: i tested this in combination with another patch that had this 'no vote' issue, so i'm sure its solved. there isn't much left to test here anyways.
  15. Christian Kuhn voted on patch set 6 V +2 CR +2 04/28/21, 23:26

  16. Christian Kuhn merged patch set 7 04/28/21, 23:27