Review main Merged

68908[DOCS] Add documentation for system extension adminpanel

Felicity Brand CR +2 V +2 Hard +664 −0 updated 05/01/21, 17:50

Commit message

This change should allow users to:
*  Discover the extension via docs.typo3.org
*  Allow different target groups like administrator,
   integrator and editor to get an idea about the feature
   set and how to use the extension.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Daniel Siepmann +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Daniel Siepmann +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 2030

Show 45 earlier messages
  1. Felicity Brand uploaded patch set 1 04/29/21, 10:11

  2. core-ci voted on patch set 1 V -1 04/29/21, 10:21 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10883

  3. Andreas Kienast uploaded patch set 2 04/29/21, 10:53

  4. Nikita Hovratov commented on patch set 2 04/29/21, 11:00

    last-docker-run-command-GENERATED.sh.txt:1 Unresolved

    The generated part should be removed.
  5. Nikita Hovratov uploaded patch set 3 04/29/21, 11:04

  1. core-ci voted on patch set 2 V +1 04/29/21, 11:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10885

  2. core-ci voted on patch set 3 V +1 04/29/21, 11:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10887

  3. Nikita Hovratov uploaded patch set 4 04/29/21, 11:34

  4. Nikita Hovratov commented on patch set 4 04/29/21, 11:36

    Look good, I only fixed the formatting of the PHP code examples.
  5. core-ci voted on patch set 4 V +1 04/29/21, 11:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10889

  6. Andreas Kienast commented on patch set 4 04/29/21, 11:50

    Index.rst:45 Unresolved

    Typo in filename, should be `InstallActivate.png`
  7. Nikita Hovratov uploaded patch set 5 04/29/21, 12:34

  8. core-ci voted on patch set 5 V +1 04/29/21, 12:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10896

  9. Nikita Hovratov uploaded patch set 6 04/29/21, 12:47

  10. Nikita Hovratov updated the commit message in patch set 7 04/29/21, 12:50

  11. core-ci voted on patch set 6 V +1 04/29/21, 12:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10897

  12. core-ci voted on patch set 7 V +1 04/29/21, 13:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10898

  13. Nikita Hovratov uploaded patch set 8 04/29/21, 13:10

  14. core-ci voted on patch set 8 V +1 04/29/21, 13:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10900

  15. Daniel Siepmann commented on patch set 8 04/30/21, 05:35

    Thanks for that addition. I didn't thought it might contain so much info which is very valuable. Looking forward to use your documentation to extend the admin panel for one of our customer. Just found some minor technical things. Will push another patchset to fix these things.

    Index.rst:14

    t3tsconfig is not defined, no link will be generated. That has to be defined within Settings.cfg.

    Settings.cfg:19

    Should be master. The backport to 10.4 should switch this to 10.4

    Settings.cfg:20

    Should be master. The backport to 10.4 should switch this to 10.4
  16. Daniel Siepmann uploaded patch set 9 04/30/21, 05:36

  17. Daniel Siepmann rebased onto patch set 10 04/30/21, 05:38

  18. Daniel Siepmann commented on patch set 10 V +1 CR +1 04/30/21, 05:38

    Index.rst:14 Reply

    Done

    Settings.cfg:19 Reply

    Done

    Settings.cfg:20 Reply

    Done
  19. core-ci voted on patch set 9 V +1 04/30/21, 05:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10957

  20. core-ci voted on patch set 10 V +1 04/30/21, 05:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10958

  21. Daniel Goerz voted on patch set 10 V +1 CR +1 04/30/21, 07:32

  22. Nikita Hovratov voted on patch set 10 V +1 CR +1 04/30/21, 07:44

  23. Oli Bartsch voted on patch set 10 V +1 CR +1 04/30/21, 08:55

  24. Christian Kuhn commented on patch set 10 V +2 CR +2 05/01/21, 17:49

    so many votes and nobody merges? i'll go ahead now. this should give us a first rendering so we can still fine tune if needed.
  25. Christian Kuhn merged patch set 11 05/01/21, 17:50