Review main Merged

68909[TASK] Add ContainerInterface->get() to dynamicReturnTypeMeta.json

Christian Kuhn CR +2 V +2 Easy +5 −0 updated 04/29/21, 16:36

Commit message

Even though ContainerInterface->get() can return 'mixed', it
returns 'object|null' with our symfony DI based implementation.
To help IDE's object resolving, dynamicReturnTypeMeta.json now
declares an instance of the first argument is returned.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 04/29/21, 11:34

  2. core-ci voted on patch set 1 V +1 04/29/21, 11:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10888

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 04/29/21, 11:50

  4. Christian Kuhn updated the commit message in patch set 2 04/29/21, 11:53

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 04/29/21, 11:54

  6. core-ci voted on patch set 2 V +1 04/29/21, 12:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10893

  7. Daniel Goerz voted on patch set 2 CR +1 04/29/21, 14:17

  8. Daniel Goerz voted on patch set 2 V +1 04/29/21, 14:25

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 04/29/21, 14:25

  10. Christian Kuhn merged patch set 3 04/29/21, 14:25

  11. Benjamin Franzke commented on patch set 3 04/29/21, 16:36

    Unresolved

    Post merge note: The service parameter isn't required to be a class name, it by convention almost always is, but it may be an arbitrary string. We have services like 'cache.core' (which are given as parameter=0). I'm not an IDE user, what does the IDE report in that case? Do you see errors because return type is detected as invalid class?