Review main Merged

68910[BUGFIX] Restore workspace filter in Belog module

Oli Bartsch CR +2 V +2 Easy +14 −14 updated 04/29/21, 14:12

Commit message

The `workspacesExtensionLoaded` variable is
removed from the Template, since it is never set
and therefore always equals to FALSE.

The previous "is workspaces loaded" check is
now directly integrated in the already existing
`showWorkspaceSelector` check.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Oli Bartsch uploaded patch set 1 04/29/21, 11:39

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 04/29/21, 11:43

  3. core-ci voted on patch set 1 V +1 04/29/21, 11:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10890

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/29/21, 14:12

  5. Benni Mack merged patch set 2 04/29/21, 14:12