Review main Merged

68911[BUGFIX] Use correct route path for submodule request

Oli Bartsch CR +2 V +2 Easy +15 −11 updated 04/29/21, 14:16

Commit message

The path for the Belog module changed in v11 and does
now contain the `/module` prefix. Since it's obviously
never a good idea to use such hard-coded values, as can
be seen in this example, the route path is now generated
by the UriBuilder. This will prevent further bugfixes
in case the path structure will change again.

Additionally, the $GLOBALS['TYPO3_REQUEST'] declaration
is removed, since #93853 was already merged.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Oli Bartsch uploaded patch set 1 04/29/21, 11:49

  2. core-ci voted on patch set 1 V +1 04/29/21, 12:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10892

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 04/29/21, 12:04

  4. Oli Bartsch uploaded patch set 2 04/29/21, 12:20

  5. Oli Bartsch updated the commit message in patch set 3 04/29/21, 12:21

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 04/29/21, 12:27

  7. core-ci voted on patch set 2 V +1 04/29/21, 12:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10894

  8. core-ci voted on patch set 3 V +1 04/29/21, 12:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10895

  9. Daniel Goerz voted on patch set 3 V +2 CR +2 04/29/21, 14:16

  10. Daniel Goerz merged patch set 4 04/29/21, 14:16