Review main Merged

68912[BUGFIX] Fix and clean up EXT:belog module

Oli Bartsch CR +2 V +2 Hard +184 −79 updated 04/29/21, 17:29

Commit message

Fixes
=====

* Fix DateTimePicker by adding the correct format
  as required since updating to flatpickr in #91606
* Restore clearable functionality of DateTime fields
  by adding a new TypeScript Module, which properly
  initializes those fields.
* Unify size of form fields again and fix position
  of the submit button and the `groupByPage` checkbox
* Add bootstrap v5 compatible markup to the `groupByPage`
  checkbox

Cleanup
=======

* Unify UX by using the `actions-calendar` icons,
  like FormEngine does, instead of font awesome.
* Add type annotations and return types, where possible
* Avoid usage of ObjectManager->get()

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1220

  1. Oli Bartsch uploaded patch set 1 04/29/21, 13:18

  2. core-ci voted on patch set 1 V -1 04/29/21, 13:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10902

  3. Oli Bartsch uploaded patch set 2 04/29/21, 13:33

  4. core-ci voted on patch set 2 V -1 04/29/21, 13:44 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10904

  5. Oli Bartsch uploaded patch set 3 04/29/21, 14:42

  6. Oli Bartsch uploaded patch set 4 04/29/21, 14:44

  7. Oli Bartsch uploaded patch set 5 04/29/21, 14:48

  8. core-ci voted on patch set 3 V -1 04/29/21, 14:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10909

  9. core-ci voted on patch set 4 V -1 04/29/21, 14:56 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10910

  10. core-ci voted on patch set 5 V -1 04/29/21, 14:58 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10911

  11. Oli Bartsch uploaded patch set 6 04/29/21, 15:27

  12. core-ci voted on patch set 6 V -1 04/29/21, 15:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10915

  13. Oli Bartsch uploaded patch set 7 04/29/21, 15:57

  14. Oli Bartsch uploaded patch set 8 04/29/21, 16:05

  15. core-ci voted on patch set 7 V +1 04/29/21, 16:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10917

  16. core-ci voted on patch set 8 V +1 04/29/21, 16:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10919

  17. Oli Bartsch commented on patch set 8 04/29/21, 16:21

    This change is ready for review.
    This change is ready for review.
  18. Benni Mack voted on patch set 8 V +1 CR +1 04/29/21, 17:20

  19. Christian Kuhn voted on patch set 8 V +2 CR +2 04/29/21, 17:29

  20. Christian Kuhn merged patch set 9 04/29/21, 17:29