Review main Merged

68914[TASK] Avoid ObjectManager->get() in ext:irre_tutorial

Christian Kuhn CR +2 V +2 Normal +44 −54 updated 04/29/21, 21:09

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 710

  1. Christian Kuhn uploaded patch set 1 04/29/21, 15:20

  2. core-ci voted on patch set 1 V +1 04/29/21, 15:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10914

  3. Christian Kuhn updated the commit message in patch set 2 04/29/21, 17:26

  4. Benni Mack commented on patch set 2 V +1 CR +1 04/29/21, 17:35

    please merge directly, as it only touches tests.
  5. core-ci voted on patch set 2 V +1 04/29/21, 17:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10926

  6. Oli Bartsch updated the commit message in patch set 3 04/29/21, 20:57

  7. core-ci voted on patch set 3 V +1 04/29/21, 21:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10940

  8. Jochen Roth voted on patch set 3 V +1 CR +1 04/29/21, 21:09

  9. Oli Bartsch voted on patch set 3 V +2 CR +2 04/29/21, 21:09

  10. Oli Bartsch merged patch set 4 04/29/21, 21:09