68915[BUGFIX] Resolve WS overlays in Extbase JOIN queries properly
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Ralf Merz +1
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php18+154 −82
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/blogs.xml+4 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/category-mm.xml+18 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/WorkspaceTest.php+44 −5
Review log 1519
-
Benni Mack uploaded patch set 1 04/29/21, 15:55
-
core-ci voted on patch set 1 V +1 04/29/21, 16:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10916
-
Benni Mack uploaded patch set 2 04/29/21, 16:59
-
core-ci voted on patch set 2 V +1 04/29/21, 17:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10922
-
Ralf Merz commented on patch set 2 CR +1 04/30/21, 05:37
Hey Benni, looks fine by reading. I've just added a few CGL related comments. And a I wanna ask about the lines around 570: In one statement you're using the cool "??" operator, but a few lines later we go with the "isset() and "> 0". Could the "??" also work there or is it intended to be like this? Otherwise: 👍 😊Typo3DbBackend.php:573The closing round and opening curly bracket after the last condition should be on a new lineTypo3DbBackend.php:579The closing round and opening curly bracket after the last condition should be on a new lineTypo3DbBackend.php:600I'd write "So we must set the language used for overlay to the language of the current record."Typo3DbBackend.php:605The closing round and opening curly bracket after the last condition should be on a new lineTypo3DbBackend.php:620missing "are": ...limits are not met... -
Benni Mack uploaded patch set 3 04/30/21, 08:20
-
core-ci voted on patch set 3 V +1 04/30/21, 08:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10959
-
Ralf Merz commented on patch set 3 CR +1 04/30/21, 08:39
Thanks for the changes 👍Typo3DbBackend.php:573ReplyDoneTypo3DbBackend.php:579ReplyDoneTypo3DbBackend.php:600ReplyDoneTypo3DbBackend.php:605ReplyDoneTypo3DbBackend.php:620ReplyDone -
Oli Bartsch commented on patch set 3 04/30/21, 09:31
Typo3DbBackend.php:523Just is_array($row) should be fine as it implies that row !== null. Alternatively we could also check for an empty array with `$row !== []`.Typo3DbBackend.php:551Same es above.Typo3DbBackend.php:624This does not happen here anymore, right? -
Benni Mack commented on patch set 3 04/30/21, 09:35
Typo3DbBackend.php:624Replysure, this happens still in versionOL() which is called later-on -
Benni Mack uploaded patch set 4 04/30/21, 09:36
-
Oli Bartsch commented on patch set 4 V +1 CR +1 04/30/21, 09:46
Typo3DbBackend.php:624ReplyOk, I was referring to this function which does not call versionOL(). But I'm fine with keeping this information here. -
core-ci voted on patch set 4 V +1 04/30/21, 09:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10964
-
Benni Mack commented on patch set 4 04/30/21, 10:04
Typo3DbBackend.php:624ReplyAck -
Nikita Hovratov voted on patch set 4 V +1 04/30/21, 10:12
-
Christian Kuhn voted on patch set 4 CR +1 04/30/21, 10:15
-
Ralf Merz commented on patch set 4 CR +1 04/30/21, 10:29
👍 I've seen the comments of Oliver have been addressed.Typo3DbBackend.php:523ReplyDoneTypo3DbBackend.php:551ReplyDone -
Benni Mack voted on patch set 4 V +2 CR +2 04/30/21, 10:30
-
Benni Mack merged patch set 5 04/30/21, 10:30