Review main Merged

68918[BUGFIX] Apply TCAdefaults to DataHandler if FormEngine was not used before

Benni Mack CR +2 V +2 Easy +5 −0 updated 05/01/21, 11:45

Commit message

If TCAdefaults.pages.categories = 4 is used in userTSconfig, and a new
page is created via Drag&Drop or via "Create Multiple New Pages" via
ClickMenu, TCAdefaults are now added to the incomingFieldArray and
not just the fieldArray.

This is also great for translations (using "Just Localized"(tm) technology),
where the defaults are respected as well now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 04/29/21, 18:25

  2. Benni Mack updated the commit message in patch set 2 04/29/21, 18:26

  3. core-ci voted on patch set 1 V +1 04/29/21, 18:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10929

  4. core-ci voted on patch set 2 V +1 04/29/21, 18:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10930

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 04/29/21, 20:27

  6. Guido Schmechel voted on patch set 2 V +1 CR +1 05/01/21, 10:13

  7. Benni Mack voted on patch set 2 V +2 CR +2 05/01/21, 11:44

  8. Benni Mack merged patch set 3 05/01/21, 11:45