Review main Merged

68921[BUGFIX] Log DataHandler errors instead of FlashMessage

Benni Mack CR +2 V +2 Normal +33 −28 updated 05/05/21, 17:40

Commit message

DataHandler should log instead of creating FlashMessages
since FlashMessages fail in CLI context. Method
->printLogErrorMessages() turns DataHandler logs
into FlashMessages already and is used in appropriate
contexts like EditDocumentController and friends.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Benni Mack uploaded patch set 1 04/29/21, 19:41

  2. core-ci voted on patch set 1 V -1 04/29/21, 19:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10936

  3. Christian Kuhn uploaded patch set 2 05/05/21, 09:21

  4. core-ci voted on patch set 2 V -1 05/05/21, 09:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11188

  5. Christian Kuhn uploaded patch set 3 05/05/21, 09:38

  6. Christian Kuhn updated the commit message in patch set 4 05/05/21, 09:42

  7. Christian Kuhn voted on patch set 4 V +1 CR +1 05/05/21, 09:44

  8. core-ci voted on patch set 3 V +1 05/05/21, 09:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11191

  9. core-ci voted on patch set 4 V +1 05/05/21, 09:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11193

  10. Oliver Hader voted on patch set 4 CR +1 05/05/21, 13:58

  11. Anja Leichsenring voted on patch set 4 V +2 CR +2 05/05/21, 17:40

  12. Anja Leichsenring merged patch set 5 05/05/21, 17:40