Review main Merged

68922[BUGFIX] Fix InvalidEnumerationValueException in workspaces

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 04/29/21, 22:21

Commit message

Since there is no guard clause, dealing with
non workspace aware records, it's possible
that `t3ver_state` is not set at this point.

To prevent the InvalidEnumerationValueException
on processing the value, the null coalescing operator,
together with a proper typecast is now used.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 04/29/21, 19:55

  2. Oli Bartsch commented on patch set 1 04/29/21, 19:57

    Please see the forge issues for steps to reproduce.
  3. core-ci voted on patch set 1 V +1 04/29/21, 20:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10938

  4. Jochen Roth voted on patch set 1 V +1 CR +1 04/29/21, 21:52

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 04/29/21, 22:20

  6. Christian Kuhn merged patch set 2 04/29/21, 22:21