Review main Merged

68923[TASK] Deprecate module.navigationFrameModule

Benni Mack CR +2 V +2 Normal +57 −0 updated 09/20/21, 14:58

Commit message

The navFrameScript / navigationFrameModule functionality,
which adds an iFrame for the navigation frame for a specific
module has now been deprecated in favor of native custom
HTML tags / web components.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1014

  1. Benni Mack uploaded patch set 1 04/29/21, 21:35

  2. core-ci voted on patch set 1 V -1 04/29/21, 21:37 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10941

  3. Benjamin Franzke commented on patch set 1 05/04/21, 12:30

    In order to not forget to remove those code parts later on: We should also mark the relevant parts in the javascript as deprecated. Maybe we should also add `console.warn()` on the javascript side? Not sure, maybe we should only do that for client-side only APIs..
  4. Benni Mack uploaded patch set 2 05/06/21, 14:12

  5. core-ci voted on patch set 2 V -1 05/06/21, 14:16 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11261

  6. Benni Mack uploaded patch set 3 05/07/21, 21:44

  7. core-ci voted on patch set 3 V +1 05/07/21, 21:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11307

  8. Benni Mack uploaded patch set 4 06/14/21, 09:19

  9. core-ci voted on patch set 4 V +1 06/14/21, 09:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12391

  10. Benni Mack commented on patch set 4 09/20/21, 12:49

  11. Oliver Hader voted on patch set 4 CR +1 09/20/21, 12:52

  12. Oliver Hader voted on patch set 4 V +1 09/20/21, 12:55

  13. Benjamin Franzke voted on patch set 4 V +2 CR +2 09/20/21, 14:58

  14. Benjamin Franzke merged patch set 5 09/20/21, 14:58