Review main Merged

68924[TASK] Simplify ext:beuser moduleData handling

Christian Kuhn CR +2 V +2 Hard +128 −321 updated 04/30/21, 14:39

Commit message

* Store an array in uc instead of serialized objects
* PHP 7.4 strictness in some classes
* Simplified inheritance chain
* Drop a service class of little use by merging
  calls to controller
* Avoid another ObjectManager->get() call
* Minor bugfix that a shortcut to 'compare users'
  is not reflected in module menu drop down
* Minor cosmetics

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 813

  1. Christian Kuhn uploaded patch set 1 04/29/21, 22:14

  2. Christian Kuhn uploaded patch set 2 04/29/21, 22:18

  3. core-ci voted on patch set 1 V -1 04/29/21, 22:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10942

  4. core-ci voted on patch set 2 V +1 04/29/21, 22:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10943

  5. Christian Kuhn uploaded patch set 3 04/29/21, 23:04

  6. Christian Kuhn uploaded patch set 4 04/29/21, 23:15

  7. core-ci voted on patch set 3 V +1 04/29/21, 23:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10947

  8. Christian Kuhn uploaded patch set 5 04/29/21, 23:16

  9. core-ci voted on patch set 4 V +1 04/29/21, 23:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10948

  10. core-ci voted on patch set 5 V +1 04/29/21, 23:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10949

  11. Oli Bartsch voted on patch set 5 V +1 CR +1 04/30/21, 14:25

  12. Andreas Kienast voted on patch set 5 V +2 CR +2 04/30/21, 14:39

  13. Andreas Kienast merged patch set 6 04/30/21, 14:39