68926[TASK] Unify backend filter styling
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 29
- Build/Sources/Sass/component/_module.scss+0 −4
- Build/Sources/Sass/typo3/_main_form.scss+0 −15
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+2 −2
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+2 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/belog/Resources/Private/Partials/Content/Filter.html+18 −22
- typo3/sysext/beuser/Resources/Private/Partials/Filters/BackendUser/Index.html2+52 −51
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html+5 −4
- typo3/sysext/core/Tests/Acceptance/Backend/FileList/FileMetaDataCest.php+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.html+7 −6
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Ter.html+9 −11
- typo3/sysext/filelist/Resources/Private/Partials/SearchForm.html+10 −8
- typo3/sysext/indexed_search/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Statistic.html+11 −5
- typo3/sysext/info/Classes/Controller/PageInformationController.php+14 −4
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+14 −4
- typo3/sysext/info/Resources/Private/Language/InfoPageTsConfig.xlf+3 −0
- typo3/sysext/info/Resources/Private/Language/locallang_webinfo.xlf+9 −0
- typo3/sysext/info/Resources/Private/Partials/PageTsConfig/Menu.html+6 −3
Show 9 more files
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+3 −3
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+10 −2
- typo3/sysext/recycler/Resources/Private/Language/locallang.xlf+9 −0
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule/Index.html+21 −19
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+32 −34
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditor.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateObjectBrowserModuleFunction.html+27 −30
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/workspaces/Resources/Private/Partials/WorkingTable.html+40 −36
Review log 3954
Show 2129 earlier messages
-
Oli Bartsch uploaded patch set 1 04/29/21, 23:39
-
core-ci voted on patch set 1 V +1 04/29/21, 23:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10950
-
Christian Kuhn voted on patch set 1 V +1 CR +1 04/30/21, 10:03
-
Benjamin Franzke voted on patch set 1 CR -1 04/30/21, 10:07
-
Benjamin Franzke commented on patch set 1 04/30/21, 10:09
Hm, I the form-group margin and the col(-auto) padding add up into too much spacing. Just had a look into the documentation (and otherwise I wouldn't have voted -1), it looks like form-group is not to be combined with .col anylonger(?) https://getbootstrap.com/docs/5.0/forms/layout/#form-grid Also see https://getbootstrap.com/docs/5.0/forms/layout/#gutters -
Benjamin Franzke uploaded patch set 2 04/30/21, 11:00
-
Oli Bartsch commented on patch set 2 CR -1 04/30/21, 11:09
Would like to use this patch to unify the filters through the whole backend. Will push another patchset soon. -
core-ci voted on patch set 2 V +1 04/30/21, 11:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10967
-
Oli Bartsch commented on patch set 2 04/30/21, 12:00
Would like to use this patch to unify the filters through the backend. Will push another patchset. -
Oli Bartsch uploaded patch set 3 04/30/21, 12:22
-
Oli Bartsch marked it work in progress 04/30/21, 12:22
-
core-ci voted on patch set 3 V -1 04/30/21, 12:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10969
-
Oli Bartsch uploaded patch set 4 05/03/21, 12:13
-
core-ci voted on patch set 4 V -1 05/03/21, 12:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11049
-
Oli Bartsch uploaded patch set 5 05/03/21, 13:45
-
core-ci voted on patch set 5 V +1 05/03/21, 13:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11051
-
Oli Bartsch uploaded patch set 6 05/03/21, 14:36
-
core-ci voted on patch set 6 V +1 05/03/21, 14:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11052
-
Oli Bartsch commented on patch set 6 05/03/21, 15:03
This change is ready for review. -
Nikita Hovratov uploaded patch set 7 05/03/21, 16:56
-
Nikita Hovratov commented on patch set 7 05/03/21, 17:01
Hey, looks good. I just removed "input-group-button" class when in "form-group" so the border will be removed from the button for perfect align. There are more places having this, but this can be fixed in another patch. I just fixed the places, where you made adjustments. Another question: Can the class "form-inline-spaced" be removed completely. I can't find any usage for it anymore. -
core-ci voted on patch set 7 V +1 05/03/21, 17:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11059
-
Oli Bartsch commented on patch set 7 05/03/21, 19:12
Reply
Thanks for the adjustments. Generally yes, but not sure whether people rely on this class being available. We should think about dropping those class (float based ones) in v12 again, together with a RST. What do you think? -
Nikita Hovratov commented on patch set 7 05/03/21, 19:19
Reply
Is css considered api? I mean A LOT has changed css-wise in v11. For example complete new slide checkboxes. Extension maintainers will have to adapt no matter what. I agree with you not breaking css just for cleanness, but there has already so much changed. This is just a tiny little class, probably no one has ever used in custom extensions. -
Oli Bartsch uploaded patch set 8 05/03/21, 19:59
-
Oli Bartsch uploaded patch set 9 05/03/21, 20:04
-
Oli Bartsch commented on patch set 9 05/03/21, 20:05
Reply
Removed it. -
core-ci voted on patch set 8 V +1 05/03/21, 20:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11071
-
Nikita Hovratov voted on patch set 9 V +1 CR +1 05/03/21, 20:12
-
core-ci voted on patch set 9 V +1 05/03/21, 20:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11075
-
Benjamin Franzke commented on patch set 9 CR -1 05/04/21, 04:32
Index.html:2I would prefer "align-items-end" here and then drop the "mt-auto" "hack" from the button col, because we don't really want center alignment but "flex-end" alignment. -
Benjamin Franzke uploaded patch set 10 05/04/21, 05:00
-
Benjamin Franzke commented on patch set 10 05/04/21, 05:00
Index.html:2ReplyDone -
core-ci voted on patch set 10 V +1 05/04/21, 05:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11081
-
Nikita Hovratov commented on patch set 10 V -1 05/04/21, 07:32
Go to TypoScriptObjectBrowser and click on any typoscript path. This looks not right. -
Nikita Hovratov uploaded patch set 11 05/04/21, 07:43
-
Nikita Hovratov commented on patch set 11 05/04/21, 07:46
Reply
I added a patch which: - Removes the extra col-auto when already in row-cols-auto. - Fixed TS-Objectbrowser view for editing typoscript properties. - Fixed DB-check->Full Search->Advanced Query->Load/Save Query form. -
Nikita Hovratov updated the commit message in patch set 12 05/04/21, 07:50
-
core-ci voted on patch set 11 V +1 05/04/21, 08:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11084
-
core-ci voted on patch set 12 V +1 05/04/21, 08:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11085
-
Benjamin Franzke commented on patch set 12 CR -1 05/04/21, 08:07
Reply
@Nikita: It's fine for me to remove col-auto because of row-cols-auto, but we'd need to substitute that with class="col" then, see documentation: https://getbootstrap.com/docs/5.0/layout/grid/#row-columns <div class="row row-cols-auto"> <div class="col">Column</div> <div class="col">Column</div> <div class="col">Column</div> <div class="col">Column</div> </div> And it really makes sense, this plain <div> classes are otherwise hard to identify as col-wrappers… -
Nikita Hovratov commented on patch set 12 05/04/21, 08:09
Reply
Yes, just discussed it with Oli. Will add it back, event if they do nothing. -
Nikita Hovratov uploaded patch set 13 05/04/21, 08:29
-
core-ci voted on patch set 13 V +1 05/04/21, 08:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11086
-
Oli Bartsch voted on patch set 13 V +1 CR +1 05/04/21, 08:48
-
Nikita Hovratov voted on patch set 13 V +1 CR +1 05/04/21, 08:49
-
Oli Bartsch commented on patch set 13 V 0 CR -1 05/04/21, 08:59
Info module still uses filter without a label. Will take care. -
Oli Bartsch uploaded patch set 14 05/04/21, 09:29
-
Benjamin Franzke uploaded patch set 15 05/04/21, 09:36
-
core-ci voted on patch set 14 V +1 05/04/21, 09:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11088
-
core-ci voted on patch set 15 V +1 05/04/21, 09:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11089
-
Nikita Hovratov voted on patch set 15 V +1 CR +1 05/04/21, 09:48
-
Oli Bartsch voted on patch set 15 V +2 CR +2 05/04/21, 09:52
-
Oli Bartsch merged patch set 16 05/04/21, 09:52