Review main Merged

68926[TASK] Unify backend filter styling

Oli Bartsch CR +2 V +2 Hard +320 −269 updated 05/04/21, 09:52

Commit message

Improves the overall look and feel of the filters in
various backend modules, thanks to the new bootstrap v5
grid. We can therefore now rely on flex-form instead of
float technology. By using the `g-X` gutter classes and
the `align-items-X` arrangement classes, we ensure the
positioning and spacing is the same in each module.

This allows to effectively remove the `form-inline-spaced`
class since this can easily be done with flex-form
and the mentioned classes in bootstrap v5.

Adjustments done:

* Use of flex-form to align and position form fields
* Add missing labels and unify arrangement
* Adjust size and position of form components
* Unify select field size
* Unify search field display
* Unify submit and reset button styles

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 29

Show 9 more files

Review log 3954

Show 2129 earlier messages
  1. Oli Bartsch uploaded patch set 1 04/29/21, 23:39

  2. core-ci voted on patch set 1 V +1 04/29/21, 23:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10950

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 04/30/21, 10:03

  4. Benjamin Franzke voted on patch set 1 CR -1 04/30/21, 10:07

  5. Benjamin Franzke commented on patch set 1 04/30/21, 10:09

    Hm, I the form-group margin and the col(-auto) padding add up into too much spacing. Just had a look into the documentation (and otherwise I wouldn't have voted -1), it looks like form-group is not to be combined with .col anylonger(?) https://getbootstrap.com/docs/5.0/forms/layout/#form-grid Also see https://getbootstrap.com/docs/5.0/forms/layout/#gutters
  6. Benjamin Franzke uploaded patch set 2 04/30/21, 11:00

  7. Oli Bartsch commented on patch set 2 CR -1 04/30/21, 11:09

    Would like to use this patch to unify the filters through the whole backend. Will push another patchset soon.
  8. core-ci voted on patch set 2 V +1 04/30/21, 11:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10967

  9. Oli Bartsch commented on patch set 2 04/30/21, 12:00

    Would like to use this patch to unify the filters through the backend. Will push another patchset.
  10. Oli Bartsch uploaded patch set 3 04/30/21, 12:22

  11. Oli Bartsch marked it work in progress 04/30/21, 12:22

  12. core-ci voted on patch set 3 V -1 04/30/21, 12:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10969

  13. Oli Bartsch uploaded patch set 4 05/03/21, 12:13

  14. core-ci voted on patch set 4 V -1 05/03/21, 12:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11049

  15. Oli Bartsch uploaded patch set 5 05/03/21, 13:45

  16. core-ci voted on patch set 5 V +1 05/03/21, 13:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11051

  17. Oli Bartsch uploaded patch set 6 05/03/21, 14:36

  18. core-ci voted on patch set 6 V +1 05/03/21, 14:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11052

  19. Oli Bartsch commented on patch set 6 05/03/21, 15:03

    This change is ready for review.
  20. Nikita Hovratov uploaded patch set 7 05/03/21, 16:56

  21. Nikita Hovratov commented on patch set 7 05/03/21, 17:01

    Hey, looks good. I just removed "input-group-button" class when in "form-group" so the border will be removed from the button for perfect align. There are more places having this, but this can be fixed in another patch. I just fixed the places, where you made adjustments. Another question: Can the class "form-inline-spaced" be removed completely. I can't find any usage for it anymore.
  22. core-ci voted on patch set 7 V +1 05/03/21, 17:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11059

  23. Oli Bartsch commented on patch set 7 05/03/21, 19:12

    Reply

    Thanks for the adjustments. Generally yes, but not sure whether people rely on this class being available. We should think about dropping those class (float based ones) in v12 again, together with a RST. What do you think?
  24. Nikita Hovratov commented on patch set 7 05/03/21, 19:19

    Reply

    Is css considered api? I mean A LOT has changed css-wise in v11. For example complete new slide checkboxes. Extension maintainers will have to adapt no matter what. I agree with you not breaking css just for cleanness, but there has already so much changed. This is just a tiny little class, probably no one has ever used in custom extensions.
  25. Oli Bartsch uploaded patch set 8 05/03/21, 19:59

  26. Oli Bartsch uploaded patch set 9 05/03/21, 20:04

  27. Oli Bartsch commented on patch set 9 05/03/21, 20:05

    Reply

    Removed it.
  28. core-ci voted on patch set 8 V +1 05/03/21, 20:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11071

  29. Nikita Hovratov voted on patch set 9 V +1 CR +1 05/03/21, 20:12

  1. core-ci voted on patch set 9 V +1 05/03/21, 20:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11075

  2. Benjamin Franzke commented on patch set 9 CR -1 05/04/21, 04:32

    Index.html:2

    I would prefer "align-items-end" here and then drop the "mt-auto" "hack" from the button col, because we don't really want center alignment but "flex-end" alignment.
  3. Benjamin Franzke uploaded patch set 10 05/04/21, 05:00

  4. Benjamin Franzke commented on patch set 10 05/04/21, 05:00

    Index.html:2 Reply

    Done
  5. core-ci voted on patch set 10 V +1 05/04/21, 05:10 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11081

  6. Nikita Hovratov commented on patch set 10 V -1 05/04/21, 07:32

    Go to TypoScriptObjectBrowser and click on any typoscript path. This looks not right.
  7. Nikita Hovratov uploaded patch set 11 05/04/21, 07:43

  8. Nikita Hovratov commented on patch set 11 05/04/21, 07:46

    Reply

    I added a patch which: - Removes the extra col-auto when already in row-cols-auto. - Fixed TS-Objectbrowser view for editing typoscript properties. - Fixed DB-check->Full Search->Advanced Query->Load/Save Query form.
  9. Nikita Hovratov updated the commit message in patch set 12 05/04/21, 07:50

  10. core-ci voted on patch set 11 V +1 05/04/21, 08:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11084

  11. core-ci voted on patch set 12 V +1 05/04/21, 08:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11085

  12. Benjamin Franzke commented on patch set 12 CR -1 05/04/21, 08:07

    Reply

    @Nikita: It's fine for me to remove col-auto because of row-cols-auto, but we'd need to substitute that with class="col" then, see documentation: https://getbootstrap.com/docs/5.0/layout/grid/#row-columns <div class="row row-cols-auto"> <div class="col">Column</div> <div class="col">Column</div> <div class="col">Column</div> <div class="col">Column</div> </div> And it really makes sense, this plain <div> classes are otherwise hard to identify as col-wrappers…
  13. Nikita Hovratov commented on patch set 12 05/04/21, 08:09

    Reply

    Yes, just discussed it with Oli. Will add it back, event if they do nothing.
  14. Nikita Hovratov uploaded patch set 13 05/04/21, 08:29

  15. core-ci voted on patch set 13 V +1 05/04/21, 08:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11086

  16. Oli Bartsch voted on patch set 13 V +1 CR +1 05/04/21, 08:48

  17. Nikita Hovratov voted on patch set 13 V +1 CR +1 05/04/21, 08:49

  18. Oli Bartsch commented on patch set 13 V 0 CR -1 05/04/21, 08:59

    Info module still uses filter without a label. Will take care.
  19. Oli Bartsch uploaded patch set 14 05/04/21, 09:29

  20. Benjamin Franzke uploaded patch set 15 05/04/21, 09:36

  21. core-ci voted on patch set 14 V +1 05/04/21, 09:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11088

  22. core-ci voted on patch set 15 V +1 05/04/21, 09:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11089

  23. Nikita Hovratov voted on patch set 15 V +1 CR +1 05/04/21, 09:48

  24. Oli Bartsch voted on patch set 15 V +2 CR +2 05/04/21, 09:52

  25. Oli Bartsch merged patch set 16 05/04/21, 09:52