Review main Merged

68928[BUGFIX] Add active class to correct element in EXT:workspaces

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 04/30/21, 11:06

Commit message

The tablist inside the element information modal
in the workspaces module did not longer set the
active state on the correct tab item.

This is due to a change in bootstrap 5, since an
active tab is highlighted by setting the `active`
class on the tab item link (`nav-link`) instead of
the tab item (`nav-item`) itself.

This is fixed by adding the `active` class to the
correct element again.

Further reference:
https://getbootstrap.com/docs/5.0/components/navs-tabs

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Oli Bartsch uploaded patch set 1 04/30/21, 00:36

  2. core-ci voted on patch set 1 V +1 04/30/21, 00:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10952

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 04/30/21, 10:07

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/30/21, 11:06

  5. Benni Mack merged patch set 2 04/30/21, 11:06