Review main Merged

6893[BUGFIX] PHP warnings may show up in the List module

Dmitry Dulepov CR +2 V +2 Normal +47 −39 updated 06/03/13, 20:49

Commit message

If the table is defined in $TCA but it misses "columns" array,
there will be a warning in the List module when searching for
any phrase. Implement a check that "columns" entry exists and
write a log message if it does not.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Stefan Neufeind +1
    • Sebastian Fischer +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 22

  1. Dmitry Dulepov commented on patch set 1 03/07/12, 07:41

    I did not modify those lines, they are only shifted inside "if". If I modify them, it would be harder to understand when you check the patch with an option to ignore whitespace change (it ignores only leading whitespaces).
  2. Dmitry Dulepov commented on patch set 1 03/07/12, 07:41

    There is a conflicting patch for the same issue: https://review.typo3.org/6883
  3. Stefan Neufeind commented on patch set 2 03/07/12, 07:41

    Looks good to me, but someone else must approve
  4. Stefan Neufeind commented on patch set 2 03/07/12, 07:41

    Philipp: how about the merge? this is targeted as a bugfix down to 4.5 while 6883 is a new feature for 4.7 then. Could you please have a look at this patch and make up your mind about the -1 you gave?
  5. Markus Klein commented on patch set 2 3 comments 03/07/12, 07:41

    I would prefer that you didn't submit this Will push new version.
  6. Tolleiv Nietsch commented on patch set 3 03/07/12, 07:41

    Verified; Looks good to me, but someone else must approve
  7. Tolleiv Nietsch commented on patch set 3 V 0 03/07/12, 07:41

    by team member; Looks good to me, approved Dmitry this one has enough votes - would you mind to take over the merging and patches for the other branches?
  8. Stefan Neufeind commented on patch set 3 03/07/12, 07:41

    Verified; Looks good to me, but someone else must approve adjust Releases-line before commit
  9. Markus Klein uploaded patch set 3 03/07/12, 07:41

  10. Oliver Hader uploaded patch set 2 03/07/12, 07:41

  11. Oliver Hader commented on patch set 2 03/07/12, 07:41

    Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Georg Ringer <mail@ringerge.org> V:1, R:1 from Simon Schaufelberger <simonschaufi@googlemail.com>
  12. Georg Ringer commented on patch set 1 03/07/12, 07:41

    Looks good to me, but someone else must approve would be great if you could fix the cgl on the lines you touched

    class.db_list.inc:847

    cgl, whitespace around the =

    class.db_list.inc:854

    cgl

    class.db_list.inc:870

    cgl
  13. Sebastian Fischer commented on patch set 3 03/07/12, 07:41

    Looks good to me, but someone else must approve
  14. Philipp Gampe commented on patch set 2 03/07/12, 07:41

    I would prefer that you didn't submit this Please merge with https://review.typo3.org/#change,6883
  15. Philipp Gampe commented on patch set 2 03/07/12, 07:41

    No score
  16. Philipp Gampe commented on patch set 2 03/07/12, 07:41

    Looks good to me, but someone else must approve
  17. Philipp Gampe commented on patch set 3 03/07/12, 07:41

    Looks good to me, but someone else must approve
  18. Simon Schaufelberger commented on patch set 1 03/07/12, 07:41

    Verified; Looks good to me, but someone else must approve
  19. Mr. Jenkins commented on patch set 1 03/07/12, 07:41

  20. Mr. Jenkins commented on patch set 2 03/07/12, 07:41

  21. Mr. Jenkins commented on patch set 3 03/07/12, 07:41

  22. Steffen Ritter merged patch set 3 03/07/12, 07:41