6893[BUGFIX] PHP warnings may show up in the List module
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Stefan Neufeind +1
- Sebastian Fischer +1
- Philipp Gampe +1
-
Verified V +2
- Tolleiv Nietsch +2
- Stefan Neufeind +1
Issues 1
Files 1
Review log 22
-
Dmitry Dulepov commented on patch set 1 03/07/12, 07:41
I did not modify those lines, they are only shifted inside "if". If I modify them, it would be harder to understand when you check the patch with an option to ignore whitespace change (it ignores only leading whitespaces). -
Dmitry Dulepov commented on patch set 1 03/07/12, 07:41
There is a conflicting patch for the same issue: https://review.typo3.org/6883 -
Stefan Neufeind commented on patch set 2 03/07/12, 07:41
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 03/07/12, 07:41
Philipp: how about the merge? this is targeted as a bugfix down to 4.5 while 6883 is a new feature for 4.7 then. Could you please have a look at this patch and make up your mind about the -1 you gave? -
Markus Klein commented on patch set 2 3 comments 03/07/12, 07:41
I would prefer that you didn't submit this Will push new version. -
Tolleiv Nietsch commented on patch set 3 03/07/12, 07:41
Verified; Looks good to me, but someone else must approve -
Tolleiv Nietsch commented on patch set 3 V 0 03/07/12, 07:41
by team member; Looks good to me, approved Dmitry this one has enough votes - would you mind to take over the merging and patches for the other branches? -
Stefan Neufeind commented on patch set 3 03/07/12, 07:41
Verified; Looks good to me, but someone else must approve adjust Releases-line before commit -
Markus Klein uploaded patch set 3 03/07/12, 07:41
-
Oliver Hader uploaded patch set 2 03/07/12, 07:41
-
Oliver Hader commented on patch set 2 03/07/12, 07:41
Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Georg Ringer <mail@ringerge.org> V:1, R:1 from Simon Schaufelberger <simonschaufi@googlemail.com> -
Georg Ringer commented on patch set 1 03/07/12, 07:41
Looks good to me, but someone else must approve would be great if you could fix the cgl on the lines you touchedclass.db_list.inc:847cgl, whitespace around the =class.db_list.inc:854cglclass.db_list.inc:870cgl -
Sebastian Fischer commented on patch set 3 03/07/12, 07:41
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 03/07/12, 07:41
I would prefer that you didn't submit this Please merge with https://review.typo3.org/#change,6883 -
Philipp Gampe commented on patch set 2 03/07/12, 07:41
No score -
Philipp Gampe commented on patch set 2 03/07/12, 07:41
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 03/07/12, 07:41
Looks good to me, but someone else must approve -
Simon Schaufelberger commented on patch set 1 03/07/12, 07:41
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/07/12, 07:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2492/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/07/12, 07:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2647/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/07/12, 07:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3132/ : SUCCESS -
Steffen Ritter merged patch set 3 03/07/12, 07:41