Review main Merged

68931[TASK] Reduce Extbase usages in EXT:seo

Benni Mack CR +2 V +2 Normal +22 −42 updated 05/05/21, 18:01

Commit message

Language and Site objects can be retrieved from TSFE
in HrefLangGenerator as well as TypoScript plugin
configuration in XmlSitemapRenderer.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack uploaded patch set 1 04/30/21, 18:56

  2. core-ci voted on patch set 1 V +1 04/30/21, 19:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10983

  3. Christian Kuhn uploaded patch set 2 05/05/21, 11:03

  4. Christian Kuhn commented on patch set 2 V +1 CR +1 05/05/21, 11:04

    Tested, debugged and break pointed both HrefLangGenerator and XmlSitemapRenderer - works as before.
  5. core-ci voted on patch set 2 V +1 05/05/21, 11:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11199

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 05/05/21, 18:01

  7. Anja Leichsenring merged patch set 3 05/05/21, 18:01