Review main Merged

68953[BUGFIX] Enable overriding header of backend preview again

Nikita Hovratov CR +2 V +2 Easy +22 −20 updated 09/17/21, 20:40

Commit message

Since commit e09082f (v10 release) the possibility to override the
preview header was gone. This patch moves the drawItem hook out of
the renderPageModulePreviewContent method to be able to pass the before
rendered previewHeader to it.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1420

  1. Nikita Hovratov uploaded patch set 1 04/30/21, 20:08

  2. core-ci voted on patch set 1 V +1 04/30/21, 20:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10986

  3. Nikita Hovratov updated the commit message in patch set 2 06/22/21, 15:17

  4. core-ci voted on patch set 2 V -1 06/22/21, 15:28 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12672

  5. Nikita Hovratov updated the commit message in patch set 3 06/22/21, 16:07

  6. core-ci voted on patch set 3 V -1 06/22/21, 16:18 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12675

  7. Nikita Hovratov rebased onto patch set 4 06/23/21, 07:09

  8. core-ci voted on patch set 4 V +1 06/23/21, 07:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12685

  9. Benni Mack commented on patch set 4 08/03/21, 11:52

    StandardContentPreviewRenderer.php:107

    removing the hook here sounds breaking, isn't it?
  10. Nikita Hovratov commented on patch set 4 08/03/21, 12:22

    StandardContentPreviewRenderer.php:107 Reply

    Pretty sure it works like before, so did my tests at least. I mean it was already broken beforehand.
  11. Benni Mack commented on patch set 4 08/03/21, 12:23

    StandardContentPreviewRenderer.php:107 Reply

    Yes. but backporting this to v10 means, that we need to support both "old-school" and "fluid-school" way of rendering.
  12. Nikita Hovratov commented on patch set 4 08/03/21, 12:40

    StandardContentPreviewRenderer.php:107 Reply Unresolved

    The old hook is in PageLayoutView, so this doesn't change the old behaviour at all.
  13. Wouter Wolters voted on patch set 4 CR +1 08/03/21, 20:03

  14. Benni Mack updated the commit message in patch set 5 09/17/21, 15:29

  15. Benni Mack voted on patch set 5 V +1 CR +1 09/17/21, 15:29

  16. core-ci voted on patch set 5 V -1 09/17/21, 15:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16886

  17. core-ci voted on patch set 5 V +1 09/17/21, 16:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16886

  18. Oli Bartsch voted on patch set 5 V +2 CR +2 09/17/21, 20:03

  19. Oli Bartsch merged patch set 6 09/17/21, 20:03

  20. Oliver Hader voted on patch set 6 CR +1 09/17/21, 20:40