68953[BUGFIX] Enable overriding header of backend preview again
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1420
-
Nikita Hovratov uploaded patch set 1 04/30/21, 20:08
-
core-ci voted on patch set 1 V +1 04/30/21, 20:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10986
-
Nikita Hovratov updated the commit message in patch set 2 06/22/21, 15:17
-
core-ci voted on patch set 2 V -1 06/22/21, 15:28 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12672
-
Nikita Hovratov updated the commit message in patch set 3 06/22/21, 16:07
-
core-ci voted on patch set 3 V -1 06/22/21, 16:18 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12675
-
Nikita Hovratov rebased onto patch set 4 06/23/21, 07:09
-
core-ci voted on patch set 4 V +1 06/23/21, 07:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12685
-
Benni Mack commented on patch set 4 08/03/21, 11:52
-
Nikita Hovratov commented on patch set 4 08/03/21, 12:22
StandardContentPreviewRenderer.php:107ReplyPretty sure it works like before, so did my tests at least. I mean it was already broken beforehand. -
Benni Mack commented on patch set 4 08/03/21, 12:23
StandardContentPreviewRenderer.php:107ReplyYes. but backporting this to v10 means, that we need to support both "old-school" and "fluid-school" way of rendering. -
Nikita Hovratov commented on patch set 4 08/03/21, 12:40
StandardContentPreviewRenderer.php:107Reply UnresolvedThe old hook is in PageLayoutView, so this doesn't change the old behaviour at all. -
Wouter Wolters voted on patch set 4 CR +1 08/03/21, 20:03
-
Benni Mack updated the commit message in patch set 5 09/17/21, 15:29
-
Benni Mack voted on patch set 5 V +1 CR +1 09/17/21, 15:29
-
core-ci voted on patch set 5 V -1 09/17/21, 15:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16886
-
core-ci voted on patch set 5 V +1 09/17/21, 16:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16886
-
Oli Bartsch voted on patch set 5 V +2 CR +2 09/17/21, 20:03
-
Oli Bartsch merged patch set 6 09/17/21, 20:03
-
Oliver Hader voted on patch set 6 CR +1 09/17/21, 20:40
StandardContentPreviewRenderer.php:107