Review main Merged

68959[BUGFIX] Prevent currentSubScript re-assignment for secondary modules

Benjamin Franzke CR +2 V +2 Easy +4 −2 updated 05/01/21, 19:27

Commit message

With the history-synchronization introduced in #93988,
window.currentSubScript has been unconditionally overwritten
after loading a new module in the content frame.
This causes an empty currentSubScript string to be stored
for secondary modules (modules not linked in the module menu),
and results in subsequent faults, when currentSubScript
is used to open a different page with the current module context.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Benjamin Franzke uploaded patch set 1 05/01/21, 17:25

  2. Christian Kuhn updated the commit message in patch set 2 05/01/21, 17:27

  3. core-ci voted on patch set 1 V +1 05/01/21, 17:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11020

  4. core-ci voted on patch set 2 V +1 05/01/21, 17:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11021

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 05/01/21, 17:46

  6. Benni Mack voted on patch set 2 V +1 CR +1 05/01/21, 19:10

  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 05/01/21, 19:27

  8. Benjamin Franzke merged patch set 3 05/01/21, 19:27