Review main Merged

68960[BUGFIX] Fix MultiStepWizard functionality

Nikita Hovratov CR +2 V +2 Normal +64 −65 updated 05/03/21, 16:54

Commit message

The MultiStepWizard has some obvious programming errors, which
surprisingly didn't cause any problems in TYPO3 v10. It was built
primarily with the multi step wizard of the form module in mind. This
fact reflects on some parts of the code.

As the direct commits to the module didn't change anything dramatically
it's reasonable to conclude the bootstrap v5 update revealed the flaws.

Most notably all 4 slides are now visible in the progress bar. Before
only 3 slides were visible (Step 3 was overridden with finish).

This patch fixes the prev and next logic to work properly with any size
of slides in a clear and understandable way.

Other notable changes:
- The missing progress bar titles in the form module multi step wizard
are added.
- The jQuery slideUp and slideDown of the buttons when going back to
the first step are removed as it serves no meaningful purpose.
- The hard coded forceSelection change when switching to first slide
(=true) and last slide (=false) is removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jonas Eberle +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Nikita Hovratov uploaded patch set 1 05/01/21, 18:16

  2. core-ci voted on patch set 1 V +1 05/01/21, 18:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11024

  3. Jonas Eberle commented on patch set 1 V +1 05/01/21, 19:43

    Works fine. Tested with new form and content translation wizard.
  4. Andreas Kienast voted on patch set 1 V +1 CR +1 05/02/21, 10:23

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 05/03/21, 16:54

  6. Oli Bartsch merged patch set 2 05/03/21, 16:54