Review main Merged

68961[TASK] Move Changelog files into 11.2 folder for upcoming release

Anja Leichsenring CR +2 V +2 Hard +518 −455 updated 05/03/21, 17:21

Commit message

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 34

Show 14 more files

Review log 1825

  1. Anja Leichsenring uploaded patch set 1 05/01/21, 20:40

  2. core-ci voted on patch set 1 V -1 05/01/21, 20:50 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11027

  3. Anja Leichsenring uploaded patch set 2 05/01/21, 21:01

  4. core-ci voted on patch set 2 V +1 05/01/21, 21:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11028

  5. Lina Wolf commented on patch set 2 CR -1 05/01/21, 21:33

    Unresolved

    :php`navigationComponentId" => "TYPO3/CMS/Backend/Tree/FileStorageTreeContainer` should be :php`"navigationComponentId" => "TYPO3/CMS/Backend/Tree/FileStorageTreeContainer"` in file. There are more examples where some `"` signs got missing... typo3/sysext/core/Documentation/Changelog/master/Deprecation-93944-FileTreeAsIframeMigratedToSVG-basedTree.rst
  6. Anja Leichsenring commented on patch set 3 05/02/21, 06:22

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 05/02/21, 06:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11033

  8. Lina Wolf commented on patch set 3 CR +2 05/02/21, 08:12

    Deprecation-93944-FileTreeAsIframeMigratedToSVG-basedTree.rst:42 Unresolved

    :php:`"navigationFrameModule" => "file_navframe"`

    Deprecation-93944-FileTreeAsIframeMigratedToSVG-basedTree.rst:46 Unresolved

    :php`"navigationComponentId" => "TYPO3/CMS/Backend/Tree/FileStorageTreeContainer"`

    Feature-73176-FilterableTreesInRecordSelectorsAndLinkPickers.rst:31 Unresolved

    In lists the list sign `*` should always be followed by two spaces. Otherwise the indentation is not 3 spaces which sometimes leads to rendering problems.

    Feature-93188-PossibilityToDisableHreflangPerPage.rst:13 Unresolved

    the Core should always be in Uppercase

    Feature-93209-FALAddGetFileToTYPO3CMSCoreResourceFolder.rst:21 Unresolved

    When a developer deals with ...

    Feature-93591-AllowGroupIdLookupInConditionsWithArrayOperator.rst:20 Unresolved

    e. g.

    Feature-93591-AllowGroupIdLookupInConditionsWithArrayOperator.rst:29 Unresolved

    With this syntax backend user groups can be matched in the frontend without a "like" expression on the comma-separated list of user group ids.

    Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rst:29 Unresolved

    lists need an indentation of 3, meaning two spaces after the star

    Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rst:46 Unresolved

    the editor's record

    Feature-93908-Image-decoding-attribute.rst:15 Unresolved

    Supporting browsers

    Index.rst:3 Unresolved

    why do we use a different hierarchy of headline markers here then in the other files?
  9. Andreas Kienast commented on patch set 3 CR -1 05/02/21, 09:44

    Deprecation-92494-ExtbaseEnvironmentService.rst:13 Unresolved

    AFAIK the apostrophe is correct here, we're describing a property of "TYPO3".

    Deprecation-92494-ExtbaseEnvironmentService.rst:16 Unresolved

    :php:`EnvironmentService`

    Deprecation-92992-HookT3libclasst3lib_parsehtml_procphptransformation.rst:12 Unresolved

    IMO we should reference to the FQCN `TYPO3\CMS\Core\Html\RteHtmlParser` here.

    Deprecation-93837-SpecialPropertyOfTCATypeSelect.rst:19 Unresolved

    Please add "database tables", as in "... `be_groups` database tables, the ...". Reason: by reading the parsed doc you may miss the context

    Deprecation-93944-FileTreeAsIframeMigratedToSVG-basedTree.rst:12 Unresolved

    The whole sentence reads a bit weird. Can we try "registered backend modules have"?

    Deprecation-93944-FileTreeAsIframeMigratedToSVG-basedTree.rst:13 Unresolved

    :php:`navigationFrameModule`

    Deprecation-93944-FileTreeAsIframeMigratedToSVG-basedTree.rst:22 Unresolved

    :php:`navigationFrameModule`

    Deprecation-93944-FileTreeAsIframeMigratedToSVG-basedTree.rst:23 Unresolved

    component

    Deprecation-93944-FileTreeAsIframeMigratedToSVG-basedTree.rst:30 Unresolved

    backend

    Deprecation-93944-FileTreeAsIframeMigratedToSVG-basedTree.rst:34 Unresolved

    superfluous comma

    Feature-57082-NewTCATypeLanguage.rst:18 Unresolved

    sql

    Feature-57082-NewTCATypeLanguage.rst:19 Unresolved

    "Actually" has no meaning here, can be removed.

    Feature-57082-NewTCATypeLanguage.rst:20 Unresolved

    both commas are superfluous

    Feature-57082-NewTCATypeLanguage.rst:22 Unresolved

    "Therefore, the new field allows"

    Feature-57082-NewTCATypeLanguage.rst:22 Unresolved

    "actually" is superfluous in this sentence

    Feature-57082-NewTCATypeLanguage.rst:23 Unresolved

    sql

    Feature-57082-NewTCATypeLanguage.rst:25 Unresolved

    sql

    Feature-57082-NewTCATypeLanguage.rst:95 Unresolved

    This reads strange. Let's start this sentence with "Columns defined as..." and end with "... are affected."

    Feature-73176-FilterableTreesInRecordSelectorsAndLinkPickers.rst:18 Unresolved

    `Target Page`:pn:

    Feature-73176-FilterableTreesInRecordSelectorsAndLinkPickers.rst:19 Unresolved

    `Shortcut Page`:pn:

    Feature-73176-FilterableTreesInRecordSelectorsAndLinkPickers.rst:19 Unresolved

    `Storage Page`:pn:

    Feature-73176-FilterableTreesInRecordSelectorsAndLinkPickers.rst:21 Unresolved

    `File`:pn:

    Feature-73176-FilterableTreesInRecordSelectorsAndLinkPickers.rst:22 Unresolved

    `File Reference`:pn:

    Feature-73176-FilterableTreesInRecordSelectorsAndLinkPickers.rst:38 Unresolved

    navigation

    Feature-89762-AddPaginationForFormManagement.rst:13 Unresolved

    form management

    Feature-89762-AddPaginationForFormManagement.rst:20 Unresolved

    form management

    Feature-93188-PossibilityToDisableHreflangPerPage.rst:13 Unresolved

    Core

    Feature-93188-PossibilityToDisableHreflangPerPage.rst:14 Unresolved

    the :php:`ModifyHrefLangTagsEvent` PSR-14 event

    Feature-93188-PossibilityToDisableHreflangPerPage.rst:30 Unresolved

    Please use `1`

    Feature-93209-FALAddGetFileToTYPO3CMSCoreResourceFolder.rst:12 Unresolved

    :php:`\TYPO3\CMS\Core\Resource\Folder`

    Feature-93209-FALAddGetFileToTYPO3CMSCoreResourceFolder.rst:14 Unresolved

    \TYPO3\CMS\Core\Resource\FolderInterface

    Feature-93209-FALAddGetFileToTYPO3CMSCoreResourceFolder.rst:15 Unresolved

    interface

    Feature-93591-AllowGroupIdLookupInConditionsWithArrayOperator.rst:29 Unresolved

    Please remove this judgmental statement.

    Feature-93606-PossibilityToDisableCanonicalPerPage.rst:12 Unresolved

    disable the generation of :html:`canonical`

    Feature-93606-PossibilityToDisableCanonicalPerPage.rst:14 Unresolved

    and also the :php:`ModifyUrlForCanonicalTagEvent` PSR-14 event

    Feature-93606-PossibilityToDisableCanonicalPerPage.rst:30 Unresolved

    Please use `1`

    Feature-93651-ProvideListOfAvailableSystemLocales.rst:13 Unresolved

    other locale-dependent values

    Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rst:12 Unresolved

    administrators

    Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rst:14 Unresolved

    backend language

    Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rst:19 Unresolved

    `User settings`:pn:

    Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rst:30 Unresolved

    the apostrophe is correct

    Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rst:30 Unresolved

    when changing what?

    Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rst:46 Unresolved

    administrator

    Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rst:46 Unresolved

    editor's

    Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rst:50 Unresolved

    `default`

    Feature-93857-ResizableNavigationComponentForAllElementRecordSelectors.rst:20 Unresolved

    backend users'

    Feature-93857-ResizableNavigationComponentForAllElementRecordSelectors.rst:21 Unresolved

    backend users'

    Important-93398-PossibilityToIgnoreSubmittedValuesInHiddenViewHelper.rst:13 Unresolved

    is added to Fluid's :php:`HiddenViewHelper` view helper.

    Important-93398-PossibilityToIgnoreSubmittedValuesInHiddenViewHelper.rst:15 Unresolved

    \TYPO3\CMS\Extbase\Http\ForwardResponse

    Important-93398-PossibilityToIgnoreSubmittedValuesInHiddenViewHelper.rst:16 Unresolved

    Extbase
  10. Lina Wolf wrote 05/02/21, 10:14

    Removed Code-Review+2 by Lina Wolf <112@linawolf.de>
  11. Lina Wolf uploaded patch set 4 05/02/21, 12:01

  12. Lina Wolf uploaded patch set 5 05/02/21, 12:10

  13. core-ci voted on patch set 4 V +1 05/02/21, 12:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11036

  14. core-ci voted on patch set 5 V +1 05/02/21, 12:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11037

  15. Andreas Kienast commented on patch set 5 CR -1 05/02/21, 12:27

    on it
  16. Andreas Kienast uploaded patch set 6 05/02/21, 12:45

  17. core-ci voted on patch set 6 V +1 05/02/21, 12:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11038

  18. Christian Kuhn voted on patch set 6 V +1 CR +1 05/03/21, 10:12

  19. Oli Bartsch commented on patch set 6 CR -1 05/03/21, 14:44

    On it.
  20. Oli Bartsch uploaded patch set 7 05/03/21, 15:02

  21. Oli Bartsch voted on patch set 7 V +1 CR +1 05/03/21, 15:02

  22. Christian Kuhn voted on patch set 7 V +1 CR +1 05/03/21, 15:11

  23. core-ci voted on patch set 7 V +1 05/03/21, 15:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11053

  24. Oliver Hader voted on patch set 7 V +2 CR +2 05/03/21, 17:21

  25. Oliver Hader merged patch set 8 05/03/21, 17:21