Review main Merged

68962[BUGFIX] Fix csh popover position

Nikita Hovratov CR +2 V +2 Easy +4 −8 updated 05/02/21, 10:25

Commit message

This fixes the popover position after clicking on a csh link.

Side note:
The popover loads in two steps: First it shows a "loading ..." text and
when the content is fetched the popover must be updated. Before it was
achieved by hiding and then immediately showing the popover again. This
doesn't quite work with bootstrap v5 anymore. The popover is stuck in
the middle of the process before the positioning applies.

New method: Use the "setContent" method of the bootstrap popover
instance. This method is not documented, but it can be used.
Nevertheless we should keep an eye on that, as it's not public API.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Riccardo De Contardi +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 67

  1. Nikita Hovratov uploaded patch set 1 05/02/21, 00:41

  2. core-ci voted on patch set 1 V +1 05/02/21, 00:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11029

  3. Riccardo De Contardi commented on patch set 1 V +1 05/02/21, 08:08

    tested; seems to solve https://forge.typo3.org/issues/93984
  4. Andreas Kienast voted on patch set 1 V +1 CR +1 05/02/21, 10:07

  5. Susi Moog voted on patch set 1 CR +1 05/02/21, 10:21

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 05/02/21, 10:25

  7. Andreas Kienast merged patch set 2 05/02/21, 10:25