Review 10.4 Merged

68973[BUGFIX] Handle workspace overlays in AbstractItemProvider

Oli Bartsch CR +2 V +2 Easy +19 −2 updated 05/04/21, 14:52

Commit message

The AbstractItemProvider method for fetching records
from `foreign_table`, e.g. used in selectSingle types,
missed proper workspace handling and therefore listed
the same record (online and offline) multiple times.

This is now fixed by adding the WorkspaceRestriction,
and applying proper overlay handling (e.g. removing
delete placeholder and move pointers).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch uploaded patch set 1 05/03/21, 08:40

  2. core-ci voted on patch set 1 V +1 05/03/21, 08:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11045

  3. Benni Mack voted on patch set 1 V +1 CR +1 05/04/21, 14:49

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 05/04/21, 14:52

  5. Oli Bartsch merged patch set 2 05/04/21, 14:52