Review 10.4 Merged

68975[BUGFIX] Use Address::create instead of new

Christian Kuhn CR +2 V +2 Normal +89 −22 updated 05/05/21, 11:09

Commit message

The usage of Address::create instead of a plain new ensures
compatibility with all Symfony releases. Since Symfony 5.2.6 the
behavior was changed to always return email addresses properly
quoted but this change broke our Mailer.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1121

  1. Christian Kuhn uploaded patch set 1 05/03/21, 16:39

  2. Simon Gilli voted on patch set 1 CR +1 05/03/21, 16:45

  3. core-ci voted on patch set 1 V +1 05/03/21, 16:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11057

  4. core-ci voted on patch set 1 V -1 05/03/21, 17:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11058

  5. Christian Kuhn rebased onto patch set 2 05/04/21, 13:15

  6. core-ci commented on patch set 1 05/04/21, 13:28 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11108

  7. core-ci voted on patch set 2 V +1 05/04/21, 13:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11109

  8. core-ci voted on patch set 2 V -1 05/04/21, 13:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11110

  9. Simon Gilli commented on patch set 3 05/04/21, 13:54

    Published edit on patch set 2.
  10. Simon Gilli commented on patch set 4 05/04/21, 13:54

    Published edit on patch set 3.
  11. core-ci voted on patch set 4 V -1 05/04/21, 14:00 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11119

  12. core-ci voted on patch set 3 V -1 05/04/21, 14:00 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11118

  13. Simon Gilli commented on patch set 5 05/04/21, 14:03

    Published edit on patch set 4.
  14. core-ci commented on patch set 4 05/04/21, 14:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11121

  15. core-ci voted on patch set 5 V +1 05/04/21, 14:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11122

  16. core-ci commented on patch set 5 05/04/21, 15:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11123

  17. Simon Gilli voted on patch set 5 V +1 CR +1 05/04/21, 15:28

  18. Christian Kuhn voted on patch set 5 V +2 CR +2 05/04/21, 16:39

  19. Christian Kuhn merged patch set 6 05/04/21, 16:39

  20. Markus Klein commented on patch set 6 05/05/21, 10:41

    As far as I can see this commit message has nothing to do with the code change, right? I guess something went wrong when pushing new patch sets
  21. Christian Kuhn commented on patch set 6 05/05/21, 11:09

    Reply

    Right - the commit messages matches the master change, the solution for v10 had to be different and it seems we missed an adaption in the backport :(