68976[BUGFIX] Use grid-gutter-width variable for margin
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 3
Review log 810
-
Nikita Hovratov uploaded patch set 1 05/03/21, 18:36
-
core-ci voted on patch set 1 V +1 05/03/21, 18:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11063
-
Georg Ringer voted on patch set 1 V +1 CR +1 05/03/21, 19:11
-
Benjamin Franzke commented on patch set 1 CR -1 05/04/21, 12:14
_module.scss:100Hm, we should actually use calc(var(--bs-gutter-x)/ -2) like bootstrap does. BUT: As far as I see we don't need to overwrite .row margins in this case anyway. I'd say we should just drop this .row {} overwrite. Or do you know why this could be needed at all? -
Nikita Hovratov uploaded patch set 2 05/04/21, 12:23
-
Nikita Hovratov commented on patch set 2 05/04/21, 12:24
_dropdown.scss:24Replydone_module.scss:100ReplyYou are right, this doesn't do anything there. -
Benjamin Franzke commented on patch set 2 V +1 CR +1 05/04/21, 12:24
_dropdown.scss:24ReplyDone_module.scss:100ReplyDone -
core-ci voted on patch set 2 V +1 05/04/21, 12:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11099
-
Benni Mack voted on patch set 2 V +2 CR +2 05/04/21, 13:18
-
Benni Mack merged patch set 3 05/04/21, 13:18
_dropdown.scss:24