Review main Merged

68976[BUGFIX] Use grid-gutter-width variable for margin

Nikita Hovratov CR +2 V +2 Easy +2 −7 updated 05/04/21, 13:18

Commit message

This fixes the alignment of the rows in the doc header and
the size of horizontal lines in dropdowns.

Replace the hardcoded 15px margin with the bootstrap grid-gutter-width
variable. The row margin override for .module-docheader-bar can be
removed completely.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Nikita Hovratov uploaded patch set 1 05/03/21, 18:36

  2. core-ci voted on patch set 1 V +1 05/03/21, 18:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11063

  3. Georg Ringer voted on patch set 1 V +1 CR +1 05/03/21, 19:11

  4. Benjamin Franzke commented on patch set 1 CR -1 05/04/21, 12:14

    _dropdown.scss:24

    $grid-gutter-width / -2

    _module.scss:100

    Hm, we should actually use calc(var(--bs-gutter-x)/ -2) like bootstrap does. BUT: As far as I see we don't need to overwrite .row margins in this case anyway. I'd say we should just drop this .row {} overwrite. Or do you know why this could be needed at all?
  5. Nikita Hovratov uploaded patch set 2 05/04/21, 12:23

  6. Nikita Hovratov commented on patch set 2 05/04/21, 12:24

    _dropdown.scss:24 Reply

    done

    _module.scss:100 Reply

    You are right, this doesn't do anything there.
  7. Benjamin Franzke commented on patch set 2 V +1 CR +1 05/04/21, 12:24

    _dropdown.scss:24 Reply

    Done

    _module.scss:100 Reply

    Done
  8. core-ci voted on patch set 2 V +1 05/04/21, 12:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11099

  9. Benni Mack voted on patch set 2 V +2 CR +2 05/04/21, 13:18

  10. Benni Mack merged patch set 3 05/04/21, 13:18