Review main Merged

68978[BUGFIX] Keep unmapped ?type parameter when using PageTypeDecorator

Benni Mack CR +2 V +2 Easy +33 −1 updated 05/10/21, 14:56

Commit message

This change keeps the type parameter (e.g. ?type=13) even
if PageTypeDecorator is used when building URLs but "13" is not
part of the map in the site configuration.

A test is added in order to make sure this functionality
will not break (again), see
https://review.typo3.org/c/Packages/TYPO3.CMS/+/62383
for the original fix without tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Rémy DANIEL +1
    • Henrik Elsner +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Henrik Elsner +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 05/03/21, 19:23

  2. core-ci voted on patch set 1 V +1 05/03/21, 19:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11066

  3. Henrik Elsner commented on patch set 1 V +1 CR +1 05/03/21, 19:40

    Works 👍 testet with f:uri.action and both as pagetype argument and additionalParams="{type:xxx}"
  4. Rémy DANIEL voted on patch set 1 CR +1 05/03/21, 21:25

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 05/10/21, 12:20

  6. Benni Mack voted on patch set 1 V +2 CR +2 05/10/21, 14:56

  7. Benni Mack merged patch set 2 05/10/21, 14:56