Review 9.5 Merged

68988[BUGFIX] Type check extbase parameter for array

Oli Bartsch CR +2 V +2 Normal +72 −1 updated 05/04/21, 15:24

Commit message

If an argument on a plugin namespace is not an array,
Extbase failed hard with an type error exception.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Oli Bartsch uploaded patch set 1 05/04/21, 13:02

  2. Oli Bartsch uploaded patch set 2 05/04/21, 13:05

  3. core-ci voted on patch set 1 V +1 05/04/21, 13:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11105

  4. core-ci voted on patch set 2 V +1 05/04/21, 13:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11106

  5. Benni Mack commented on patch set 2 05/04/21, 13:29

    RequestBuilder.php:171

    space is missing "$bodyParameters:"
  6. Oli Bartsch uploaded patch set 3 05/04/21, 13:33

  7. Oli Bartsch commented on patch set 3 05/04/21, 13:34

    RequestBuilder.php:171 Reply

    Thanks.
  8. core-ci voted on patch set 3 V +1 05/04/21, 13:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11112

  9. Benni Mack voted on patch set 3 V +1 CR +1 05/04/21, 15:17

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 05/04/21, 15:24

  11. Oli Bartsch merged patch set 4 05/04/21, 15:24