Review main Merged

68989[TASK] Add support for PHP-CS-Fixer 3.0

Benni Mack CR +2 V +2 Easy +27 −22 updated 05/04/21, 15:32

Commit message

This change raises the dev dependency PHP-CS-Fixer
to 2.19 (forward-compatible to 3.0) and 3.0,
allowing to run PHP-CS-Fixer with PHP8.

This change adapts the config file to use
the latest syntax. Using PSR-12 will be
handled in a separate followup.

Used composer commands:
- composer req friendsofphp/php-cs-fixer:"^2.19 || ^3.0" --dev
- composer req friendsofphp/php-cs-fixer:"^2.19 || ^3.0" -d typo3/sysext/core --dev --no-update

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 710

  1. Benni Mack uploaded patch set 1 05/04/21, 13:28

  2. Benni Mack uploaded patch set 2 05/04/21, 13:41

  3. core-ci voted on patch set 1 V +1 05/04/21, 13:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11111

  4. core-ci voted on patch set 2 V +1 05/04/21, 13:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11113

  5. Christian Kuhn commented on patch set 2 CR -1 05/04/21, 13:52

    tmp -1: let's see if the nightly is fine with this.
  6. core-ci commented on patch set 2 05/04/21, 14:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11116

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 05/04/21, 14:39

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 05/04/21, 14:46

  9. Benni Mack voted on patch set 2 V +2 CR +2 05/04/21, 15:32

  10. Benni Mack merged patch set 3 05/04/21, 15:32