Review main Merged

68991[TASK] gitlab-ci: PHP 8.0 functional nightlies with mariadb 10.5

Christian Kuhn CR +2 V +2 Normal +46 −13 updated 05/04/21, 17:57

Commit message

Next to pre-merge test suite, nightlies now especially run
the composer min/max functionals with PHP8. Using mariadb
10.5 to cover another DBMS variant.

Needs a friendsoftypo3/phpstan-typo3 raise:
composer require --dev friendsoftypo3/phpstan-typo3:^0.7.0

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 712

  1. Christian Kuhn uploaded patch set 1 05/04/21, 15:42

  2. core-ci voted on patch set 1 V +1 05/04/21, 15:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11126

  3. core-ci voted on patch set 1 V -1 05/04/21, 16:26 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11127

  4. Christian Kuhn uploaded patch set 2 05/04/21, 16:48

  5. core-ci voted on patch set 2 V +1 05/04/21, 16:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11135

  6. core-ci commented on patch set 2 05/04/21, 17:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11136

  7. Christian Kuhn uploaded patch set 3 05/04/21, 17:41

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 05/04/21, 17:44

  9. core-ci voted on patch set 3 V +1 05/04/21, 17:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11139

  10. Daniel Goerz voted on patch set 3 V +1 CR +1 05/04/21, 17:56

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 05/04/21, 17:56

  12. Christian Kuhn merged patch set 4 05/04/21, 17:57