Review 10.4 Merged

68994[BUGFIX] Remove deprecated reflection API usage

Benni Mack CR +2 V +2 Easy +26 −13 updated 05/04/21, 15:17

Commit message

PHP 8 deprecated a number of very old bits of the Reflection API. This
patch updates ClassSchema to use the newer equivalents.

Also fixes some unrelated PHP 8.0 errors around undefined value handling.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. Benni Mack commented on patch set 1 05/04/21, 13:50

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentAfterMovedContent.csv
  2. Benni Mack commented on patch set 2 05/04/21, 13:51

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 3 05/04/21, 13:52

    Published edit on patch set 2.
  4. Benni Mack marked it ready for review 05/04/21, 13:53

  5. Christian Kuhn commented on patch set 3 CR -1 05/04/21, 13:55

    tmp -1: let's run the v10 nightly with this, too ...
  6. core-ci voted on patch set 2 V -1 05/04/21, 14:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11115

  7. core-ci voted on patch set 3 V +1 05/04/21, 14:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11117

  8. core-ci voted on patch set 1 V -1 05/04/21, 14:06 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11114

  9. core-ci commented on patch set 3 05/04/21, 14:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11120

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 05/04/21, 14:55

  11. Benni Mack voted on patch set 3 V +2 CR +2 05/04/21, 15:17

  12. Benni Mack merged patch set 4 05/04/21, 15:17