Review main Merged

69015[TASK] Remove goToModule() inline JavaScript invocations

Oliver Hader CR +2 V +2 Normal +199 −22 updated 05/06/21, 13:24

Commit message

This change reduces the amount of inline JavaScript and transforms
`goToModule()` invocations in the TYPO3 backend user interface to use
`ActionDispatcher`'s `TYPO3.ModuleMenu.showModule` handling.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 2942

Show 1217 earlier messages
  1. Oliver Hader uploaded patch set 1 05/04/21, 16:34

  2. core-ci voted on patch set 1 V +1 05/04/21, 16:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11132

  3. Benjamin Franzke commented on patch set 1 05/04/21, 20:43

    SysLogButtonProvider.php:56

    I think we can simply link to the backend module. ModuleMenu automatically syncs state (active menu entry) after the module has been loaded since https://review.typo3.org/c/Packages/TYPO3.CMS/+/67464
  4. Benjamin Franzke uploaded patch set 2 05/04/21, 20:50

  5. Benjamin Franzke commented on patch set 2 05/04/21, 20:50

    SysLogButtonProvider.php:56 Reply

    Done
  6. core-ci voted on patch set 2 V -1 05/04/21, 21:02 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11168

  7. Benjamin Franzke uploaded patch set 3 05/04/21, 21:06

  8. Benjamin Franzke uploaded patch set 4 05/04/21, 21:16

    Rebase
  9. core-ci voted on patch set 3 V +1 05/04/21, 21:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11177

  10. core-ci voted on patch set 4 V +1 05/04/21, 21:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11178

  11. Benni Mack uploaded patch set 5 05/05/21, 14:19

  12. core-ci voted on patch set 5 V +1 05/05/21, 14:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11215

  13. Benjamin Franzke voted on patch set 5 CR +1 05/05/21, 14:42

  14. Oliver Hader voted on patch set 5 CR -1 05/05/21, 14:59

  15. Benjamin Franzke commented on patch set 5 CR -1 05/05/21, 15:00

    WarningMessagePostProcessor.php:63

    This looks wrong, this were two parameters before (opening and closing <a> tag separately). But linking to the status report is broken since 2016 in default language anyway :\ See https://github.com/TYPO3/TYPO3.CMS/commit/edbaad16482eb3451e47a05ac051594d0f9efbea#diff-50460291b966049a7f071dd0418fb08daf2d6b8ba134879a6580732bb1b59533R58 But we should move '</a>' into separate sprintf parameter again.
  16. Oliver Hader commented on patch set 5 05/05/21, 15:02

    On it..

    WarningMessagePostProcessor.php:63 Reply

    Ack
  17. Oliver Hader uploaded patch set 6 05/05/21, 15:09

  1. core-ci voted on patch set 6 V -1 05/05/21, 15:10 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11221

  2. Oliver Hader uploaded patch set 7 05/05/21, 15:10

  3. Oliver Hader uploaded patch set 8 05/05/21, 15:12

  4. Oliver Hader commented on patch set 8 05/05/21, 15:12

    Added handling in dashboard widgets as well...
  5. core-ci voted on patch set 7 V -1 05/05/21, 15:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11222

  6. Oliver Hader commented on patch set 8 05/05/21, 15:13

    Ready for reviews now, I'm done with my changes...
  7. core-ci voted on patch set 8 V -1 05/05/21, 15:22 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11223

  8. Oliver Hader uploaded patch set 9 05/05/21, 15:26

  9. Oliver Hader uploaded patch set 10 05/05/21, 15:32

  10. core-ci voted on patch set 9 V +1 05/05/21, 16:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11226

  11. core-ci voted on patch set 10 V +1 05/05/21, 16:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11227

  12. Benjamin Franzke commented on patch set 10 CR -1 05/06/21, 06:54

    Button.html:8

    Hm.. This doesn't check the interface which makes the interface kinda superfluous. I think we should better wrap this into a <dashboard.button button="{button}"> viewhelper rather that adding a utility viewhelpers that doesn't allow to perform the interface check. Will push an update.
  13. Benjamin Franzke uploaded patch set 11 05/06/21, 07:04

  14. Benjamin Franzke commented on patch set 11 05/06/21, 07:04

    Button.html:8 Reply

    Done
  15. Benjamin Franzke uploaded patch set 12 05/06/21, 07:13

  16. core-ci voted on patch set 11 V +1 05/06/21, 07:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11237

  17. Benjamin Franzke uploaded patch set 13 05/06/21, 07:17

  18. Oliver Hader commented on patch set 11 05/06/21, 07:18

    Button.html:8 Reply

    None of the interfaces were checked in the templates - I just continued like that without restructuring the Dashboard too much. That's also why I've chosen the approach of composing everything in Button.html. I was under the impression that users might be able to modify/adjust those templates - but honestly, I just don't know how that is implemented in Dashboard. Anyway, I'm fine with the recent modification using a view-helper for that...
  19. Benjamin Franzke commented on patch set 13 05/06/21, 07:24

    Button.html:8 Reply

    Hm, ok, good you say that. I wasn't aware that ButtonProviderInterface was never checked against... :O That means my changes could result in an exception for improper extensions that missed to implement ButtonProviderInterface, as the new viewhelper enforces the ButtonProviderInterface type, which was handled loosely before. Could be breaking for improper extensions, but its ok I think, as we've got following statement in ButtonProviderInterface: In case a widget should have a button in the footer of the widget, this button must implement this interface.
  20. core-ci voted on patch set 12 V +1 05/06/21, 07:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11238

  21. core-ci voted on patch set 13 V +1 05/06/21, 07:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11239

  22. Oliver Hader commented on patch set 13 05/06/21, 10:31

    Button.html:8 Reply

    Yepp (on the backward-compat part). But I'm pretty much convinced that a potential impact is really low. For people using their own `Button.html` that still would be working.
  23. Benni Mack voted on patch set 13 V +2 CR +2 05/06/21, 10:34

  24. Benni Mack merged patch set 14 05/06/21, 10:34

  25. Oliver Hader wrote 05/06/21, 13:24

    Topic set to inline-javascript