69016[TASK] Enable phpstan parameter checkPhpDocMethodSignatures
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 6
- Build/phpstan.level3.neon+1 −1
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php1+2 −2
- typo3/sysext/core/Classes/Resource/Security/FileMetadataPermissionsAspect.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+2 −2
- typo3/sysext/linkvalidator/Classes/Linktype/LinktypeInterface.php+1 −1
- phpstan.neon+10 −0
Review log 810
-
Daniel Goerz uploaded patch set 1 05/04/21, 16:42
-
Daniel Goerz wrote 05/04/21, 16:42
Topic set to phpstan -
core-ci voted on patch set 1 V +1 05/04/21, 16:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11134
-
Christian Kuhn voted on patch set 1 V +1 CR +1 05/04/21, 17:05
-
Oli Bartsch commented on patch set 1 05/04/21, 17:34
AbstractRecordCollection.php:122UnresolvedJust from reading the code, NULL seems to be possible as well, in case 'uid' is not defined. -
Daniel Goerz uploaded patch set 2 05/04/21, 17:59
-
core-ci voted on patch set 2 V +1 05/04/21, 18:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11142
-
Christian Kuhn voted on patch set 2 V +1 CR +1 05/04/21, 18:34
-
Anja Leichsenring voted on patch set 2 V +2 CR +2 05/04/21, 18:36
-
Anja Leichsenring merged patch set 3 05/04/21, 18:36