Review main Merged

69016[TASK] Enable phpstan parameter checkPhpDocMethodSignatures

Daniel Goerz CR +2 V +2 Easy +17 −7 updated 05/04/21, 18:36

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 810

  1. Daniel Goerz uploaded patch set 1 05/04/21, 16:42

  2. Daniel Goerz wrote 05/04/21, 16:42

    Topic set to phpstan
  3. core-ci voted on patch set 1 V +1 05/04/21, 16:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11134

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 05/04/21, 17:05

  5. Oli Bartsch commented on patch set 1 05/04/21, 17:34

    AbstractRecordCollection.php:122 Unresolved

    Just from reading the code, NULL seems to be possible as well, in case 'uid' is not defined.
  6. Daniel Goerz uploaded patch set 2 05/04/21, 17:59

  7. core-ci voted on patch set 2 V +1 05/04/21, 18:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11142

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 05/04/21, 18:34

  9. Anja Leichsenring voted on patch set 2 V +2 CR +2 05/04/21, 18:36

  10. Anja Leichsenring merged patch set 3 05/04/21, 18:36