Review main Merged

69018[TASK] gitlab-ci: PHP 8.0 unit test nightlies min/max

Christian Kuhn CR +2 V +2 Normal +79 −14 updated 05/04/21, 20:18

Commit message

Needs a phpdocumentor/type-resolver raise:
composer req phpdocumentor/type-resolver:^1.4

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 714

  1. Christian Kuhn uploaded patch set 1 05/04/21, 18:02

  2. core-ci voted on patch set 1 V +1 05/04/21, 18:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11143

  3. core-ci voted on patch set 1 V -1 05/04/21, 18:28 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11146

  4. Christian Kuhn uploaded patch set 2 05/04/21, 19:07

  5. Christian Kuhn updated the commit message in patch set 3 05/04/21, 19:08

  6. core-ci voted on patch set 3 V -1 05/04/21, 19:18 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11155

  7. core-ci voted on patch set 2 V -1 05/04/21, 19:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11153

  8. core-ci commented on patch set 3 05/04/21, 19:20 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11154

  9. Christian Kuhn uploaded patch set 4 05/04/21, 19:22

  10. core-ci voted on patch set 4 V +1 05/04/21, 19:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11156

  11. Daniel Goerz voted on patch set 4 V +1 CR +1 05/04/21, 19:48

  12. Anja Leichsenring voted on patch set 4 V +2 CR +2 05/04/21, 19:54

  13. Anja Leichsenring merged patch set 5 05/04/21, 19:54

  14. core-ci commented on patch set 4 05/04/21, 20:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11157