6902[TASK] swift mailer update to version 4.1.3
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Oliver Klee +1
- Jigal van Hemert +1
-
Verified V +2
- Steffen Ritter +2
- Jigal van Hemert +1
Issues 1
Files 159
- typo3/contrib/swiftmailer/classes/Swift/ByteStream/AbstractFilterableInputStream.php+23 −26
- typo3/contrib/swiftmailer/classes/Swift/ByteStream/ArrayByteStream.php+7 −9
- typo3/contrib/swiftmailer/classes/Swift/ByteStream/FileByteStream.php+93 −37
- typo3/contrib/swiftmailer/classes/Swift/CharacterReader/GenericFixedWidthReader.php+4 −5
- typo3/contrib/swiftmailer/classes/Swift/CharacterReader/UsAsciiReader.php+2 −3
- typo3/contrib/swiftmailer/classes/Swift/CharacterReader/Utf8Reader.php+2 −3
- typo3/contrib/swiftmailer/classes/Swift/CharacterReaderFactory/SimpleCharacterReaderFactory.php+12 −13
- typo3/contrib/swiftmailer/classes/Swift/CharacterStream/ArrayCharacterStream.php+7 −9
- typo3/contrib/swiftmailer/classes/Swift/CharacterStream/NgCharacterStream.php+17 −19
- typo3/contrib/swiftmailer/classes/Swift/Encoder/Base64Encoder.php+6 −7
- typo3/contrib/swiftmailer/classes/Swift/Encoder/QpEncoder.php+9 −14
- typo3/contrib/swiftmailer/classes/Swift/Encoder/Rfc2231Encoder.php+10 −12
- typo3/contrib/swiftmailer/classes/Swift/Events/CommandEvent.php+7 −9
- typo3/contrib/swiftmailer/classes/Swift/Events/CommandListener.php+2 −4
- typo3/contrib/swiftmailer/classes/Swift/Events/Event.php+5 −5
- typo3/contrib/swiftmailer/classes/Swift/Events/EventDispatcher.php+8 −10
- typo3/contrib/swiftmailer/classes/Swift/Events/EventListener.php+1 −1
- typo3/contrib/swiftmailer/classes/Swift/Events/EventObject.php+8 −9
- typo3/contrib/swiftmailer/classes/Swift/Events/ResponseEvent.php+7 −8
- typo3/contrib/swiftmailer/classes/Swift/Events/ResponseListener.php+2 −4
Show 139 more files
- typo3/contrib/swiftmailer/classes/Swift/Events/SendEvent.php+17 −18
- typo3/contrib/swiftmailer/classes/Swift/Events/SendListener.php+3 −5
- typo3/contrib/swiftmailer/classes/Swift/Events/SimpleEventDispatcher.php+23 −31
- typo3/contrib/swiftmailer/classes/Swift/Events/TransportChangeEvent.php+3 −4
- typo3/contrib/swiftmailer/classes/Swift/Events/TransportChangeListener.php+11 −13
- typo3/contrib/swiftmailer/classes/Swift/Events/TransportExceptionEvent.php+4 −6
- typo3/contrib/swiftmailer/classes/Swift/Events/TransportExceptionListener.php+2 −4
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/ArrayKeyCache.php+14 −19
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/DiskKeyCache.php+35 −18
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/DummyKeyCache.phpnew+112 −0
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/KeyCacheInputStream.php+6 −8
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/NullKeyCache.php+9 −13
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/SimpleKeyCacheInputStream.php+15 −17
- typo3/contrib/swiftmailer/classes/Swift/Mailer/ArrayRecipientIterator.php+5 −6
- typo3/contrib/swiftmailer/classes/Swift/Mailer/RecipientIterator.php+3 −3
- typo3/contrib/swiftmailer/classes/Swift/Mime/ContentEncoder/Base64ContentEncoder.php+8 −12
- typo3/contrib/swiftmailer/classes/Swift/Mime/ContentEncoder/PlainContentEncoder.php+18 −21
- typo3/contrib/swiftmailer/classes/Swift/Mime/ContentEncoder/QpContentEncoder.php+7 −7
- typo3/contrib/swiftmailer/classes/Swift/Mime/HeaderEncoder/Base64HeaderEncoder.php+2 −2
- typo3/contrib/swiftmailer/classes/Swift/Mime/HeaderEncoder/QpHeaderEncoder.php+7 −38
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/AbstractHeader.php+89 −184
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/DateHeader.php+12 −11
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/IdentificationHeader.php+39 −34
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/MailboxHeader.php+31 −32
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/ParameterizedHeader.php+30 −35
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/PathHeader.php+33 −19
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/UnstructuredHeader.php+13 −14
- typo3/contrib/swiftmailer/classes/Swift/Mime/Attachment.php+19 −19
- typo3/contrib/swiftmailer/classes/Swift/Mime/CharsetObserver.php+2 −2
- typo3/contrib/swiftmailer/classes/Swift/Mime/ContentEncoder.php+3 −6
- typo3/contrib/swiftmailer/classes/Swift/Mime/EmbeddedFile.php+6 −9
- typo3/contrib/swiftmailer/classes/Swift/Mime/EncodingObserver.php+2 −3
- typo3/contrib/swiftmailer/classes/Swift/Mime/Grammar.phpnew+163 −0
- typo3/contrib/swiftmailer/classes/Swift/Mime/Header.php+13 −13
- typo3/contrib/swiftmailer/classes/Swift/Mime/HeaderEncoder.php+2 −3
- typo3/contrib/swiftmailer/classes/Swift/Mime/HeaderFactory.php+7 −8
- typo3/contrib/swiftmailer/classes/Swift/Mime/HeaderSet.php+44 −45
- typo3/contrib/swiftmailer/classes/Swift/Mime/Message.php+66 −67
- typo3/contrib/swiftmailer/classes/Swift/Mime/MimeEntity.php+15 −18
- typo3/contrib/swiftmailer/classes/Swift/Mime/MimePart.php+36 −35
- typo3/contrib/swiftmailer/classes/Swift/Mime/ParameterizedHeader.php+3 −4
- typo3/contrib/swiftmailer/classes/Swift/Mime/SimpleHeaderFactory.php+26 −29
- typo3/contrib/swiftmailer/classes/Swift/Mime/SimpleHeaderSet.php+65 −67
- typo3/contrib/swiftmailer/classes/Swift/Mime/SimpleMessage.php+94 −81
- typo3/contrib/swiftmailer/classes/Swift/Mime/SimpleMimeEntity.php+144 −95
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Decorator/Replacements.php+8 −8
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Loggers/ArrayLogger.php+7 −7
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Loggers/EchoLogger.php+8 −8
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Pop/Pop3Connection.php+7 −7
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Pop/Pop3Exception.php+5 −6
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Reporters/HitReporter.php+5 −7
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Reporters/HtmlReporter.php+2 −4
- typo3/contrib/swiftmailer/classes/Swift/Plugins/AntiFloodPlugin.php+13 −16
- typo3/contrib/swiftmailer/classes/Swift/Plugins/BandwidthMonitorPlugin.php+18 −25
- typo3/contrib/swiftmailer/classes/Swift/Plugins/DecoratorPlugin.php+59 −29
- typo3/contrib/swiftmailer/classes/Swift/Plugins/ImpersonatePlugin.phpnew+68 −0
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Logger.php+4 −4
- typo3/contrib/swiftmailer/classes/Swift/Plugins/LoggerPlugin.php+25 −35
- typo3/contrib/swiftmailer/classes/Swift/Plugins/MessageLogger.phpnew+77 −0
- typo3/contrib/swiftmailer/classes/Swift/Plugins/PopBeforeSmtpPlugin.php+47 −49
- typo3/contrib/swiftmailer/classes/Swift/Plugins/RedirectingPlugin.phpnew+109 −0
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Reporter.php+4 −5
- typo3/contrib/swiftmailer/classes/Swift/Plugins/ReporterPlugin.php+5 −8
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Sleeper.php+2 −2
- typo3/contrib/swiftmailer/classes/Swift/Plugins/ThrottlerPlugin.php+19 −23
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Timer.php+2 −2
- typo3/contrib/swiftmailer/classes/Swift/StreamFilters/ByteArrayReplacementFilter.php+5 −6
- typo3/contrib/swiftmailer/classes/Swift/StreamFilters/StringReplacementFilter.php+6 −7
- typo3/contrib/swiftmailer/classes/Swift/StreamFilters/StringReplacementFilterFactory.php+6 −8
- typo3/contrib/swiftmailer/classes/Swift/Transport/Esmtp/Auth/CramMd5Authenticator.php+6 −9
- typo3/contrib/swiftmailer/classes/Swift/Transport/Esmtp/Auth/LoginAuthenticator.php+3 −6
- typo3/contrib/swiftmailer/classes/Swift/Transport/Esmtp/Auth/PlainAuthenticator.php+3 −6
- typo3/contrib/swiftmailer/classes/Swift/Transport/Esmtp/Authenticator.php+3 −4
- typo3/contrib/swiftmailer/classes/Swift/Transport/Esmtp/AuthHandler.php+25 −28
- typo3/contrib/swiftmailer/classes/Swift/Transport/AbstractSmtpTransport.php+95 −79
- typo3/contrib/swiftmailer/classes/Swift/Transport/EsmtpHandler.php+10 −11
- typo3/contrib/swiftmailer/classes/Swift/Transport/EsmtpTransport.php+91 −36
- typo3/contrib/swiftmailer/classes/Swift/Transport/FailoverTransport.php+12 −14
- typo3/contrib/swiftmailer/classes/Swift/Transport/IoBuffer.php+8 −10
- typo3/contrib/swiftmailer/classes/Swift/Transport/LoadBalancedTransport.php+28 −31
- typo3/contrib/swiftmailer/classes/Swift/Transport/MailInvoker.php+6 −6
- typo3/contrib/swiftmailer/classes/Swift/Transport/MailTransport.php+48 −45
- typo3/contrib/swiftmailer/classes/Swift/Transport/NullTransport.phpnew+90 −0
- typo3/contrib/swiftmailer/classes/Swift/Transport/SendmailTransport.php+21 −24
- typo3/contrib/swiftmailer/classes/Swift/Transport/SimpleMailInvoker.php+11 −12
- typo3/contrib/swiftmailer/classes/Swift/Transport/SmtpAgent.php+3 −3
- typo3/contrib/swiftmailer/classes/Swift/Transport/SpoolTransport.phpnew+116 −0
- typo3/contrib/swiftmailer/classes/Swift/Transport/StreamBuffer.php+88 −36
- typo3/contrib/swiftmailer/classes/Swift/Attachment.php+5 −8
- typo3/contrib/swiftmailer/classes/Swift/CharacterReader.php+3 −3
- typo3/contrib/swiftmailer/classes/Swift/CharacterReaderFactory.php+1 −2
- typo3/contrib/swiftmailer/classes/Swift/CharacterStream.php+9 −9
- typo3/contrib/swiftmailer/classes/Swift/ConfigurableSpool.phpnew+59 −0
- typo3/contrib/swiftmailer/classes/Swift/DependencyContainer.php+34 −35
- typo3/contrib/swiftmailer/classes/Swift/DependencyException.php+2 −3
- typo3/contrib/swiftmailer/classes/Swift/EmbeddedFile.php+5 −8
- typo3/contrib/swiftmailer/classes/Swift/Encoder.php+2 −3
- typo3/contrib/swiftmailer/classes/Swift/Encoding.php+12 −13
- typo3/contrib/swiftmailer/classes/Swift/FailoverTransport.php+4 −6
- typo3/contrib/swiftmailer/classes/Swift/FileSpool.phpnew+208 −0
- typo3/contrib/swiftmailer/classes/Swift/FileStream.php+2 −3
- typo3/contrib/swiftmailer/classes/Swift/Filterable.php+3 −4
- typo3/contrib/swiftmailer/classes/Swift/Image.php+4 −6
- typo3/contrib/swiftmailer/classes/Swift/InputByteStream.php+11 −11
- typo3/contrib/swiftmailer/classes/Swift/IoException.php+2 −3
- typo3/contrib/swiftmailer/classes/Swift/KeyCache.php+11 −13
- typo3/contrib/swiftmailer/classes/Swift/LoadBalancedTransport.php+4 −6
- typo3/contrib/swiftmailer/classes/Swift/Mailer.php+35 −90
- typo3/contrib/swiftmailer/classes/Swift/MailTransport.php+4 −6
- typo3/contrib/swiftmailer/classes/Swift/Message.php+10 −8
- typo3/contrib/swiftmailer/classes/Swift/MimePart.php+4 −6
- typo3/contrib/swiftmailer/classes/Swift/NullTransport.phpnew+38 −0
- typo3/contrib/swiftmailer/classes/Swift/OutputByteStream.php+3 −3
- typo3/contrib/swiftmailer/classes/Swift/Preferences.php+23 −8
- typo3/contrib/swiftmailer/classes/Swift/ReplacementFilterFactory.php+2 −2
- typo3/contrib/swiftmailer/classes/Swift/RfcComplianceException.php+2 −3
- typo3/contrib/swiftmailer/classes/Swift/SendmailTransport.php+4 −6
- typo3/contrib/swiftmailer/classes/Swift/SmtpTransport.php+4 −6
- typo3/contrib/swiftmailer/classes/Swift/Spool.phpnew+50 −0
- typo3/contrib/swiftmailer/classes/Swift/SpoolTransport.phpnew+44 −0
- typo3/contrib/swiftmailer/classes/Swift/StreamFilter.php+3 −3
- typo3/contrib/swiftmailer/classes/Swift/SwiftException.php+2 −2
- typo3/contrib/swiftmailer/classes/Swift/Transport.php+11 −13
- typo3/contrib/swiftmailer/classes/Swift/TransportException.php+2 −3
- typo3/contrib/swiftmailer/classes/Swift/Validate.phpnew+38 −0
- typo3/contrib/swiftmailer/classes/Swift.php+26 −14
- typo3/contrib/swiftmailer/dependency_maps/cache_deps.php+7 −7
- typo3/contrib/swiftmailer/dependency_maps/message_deps.phpnew+9 −0
- typo3/contrib/swiftmailer/dependency_maps/mime_deps.php+29 −21
- typo3/contrib/swiftmailer/dependency_maps/transport_deps.php+22 −14
- typo3/contrib/swiftmailer/CHANGESnew+45 −0
- typo3/contrib/swiftmailer/LICENSE+0 −0
- typo3/contrib/swiftmailer/mime_types.php+0 −0
- typo3/contrib/swiftmailer/preferences.php+2 −0
- typo3/contrib/swiftmailer/README+2 −2
- typo3/contrib/swiftmailer/swift_init.php+10 −4
- typo3/contrib/swiftmailer/swift_required.php+7 −2
- typo3/contrib/swiftmailer/swift_required_pear.php+7 −2
- typo3/contrib/swiftmailer/VERSION+1 −1
Review log 21
-
Oliver Klee commented on patch set 1 12/12/11, 06:56
I would prefer that you didn't submit this I'd prefer a new patch with the trailing whitespace removed (as the current patch adds trailing whitespace in quite a lot of places). -
Oliver Klee commented on patch set 1 12/12/11, 06:56
(Apart from the trailing whitespace, the patch looks okay to me.) -
Oliver Klee commented on patch set 1 12/12/11, 06:56
I do because all the whitespace changes make the real changes in the changeset harder to see. -
Oliver Klee commented on patch set 1 12/12/11, 06:56
BTW, this is only about the trailing whitespace, not any other whitespace changes. -
Oliver Klee commented on patch set 1 12/12/11, 06:56
Looks good to me, but someone else must approve Just out of curiousity: Did we remove the trailing whitespace for the last version, or did the SwitftMailer guys introduce the trailing whitespace in their version? (I'd like to have these whitespace changes out of our changesets at least for future changesets.) -
Oliver Hader uploaded patch set 3 12/12/11, 06:56
-
Oliver Hader commented on patch set 3 12/12/11, 06:56
Manually rebased to master -
Steffen Ritter commented on patch set 1 12/12/11, 06:56
Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 1 12/12/11, 06:56
Verified; Looks good to me, but someone else must approve Just wanted to push this myself, but checked bugtracker just to be sure it wasn't already done. Tested with Install Tool mail and new form wizard. @Simon : As discussed some time ago with Ernesto it could also go to 4.6 and 4.5. -
Jigal van Hemert commented on patch set 1 12/12/11, 06:56
@Oliver, as Simon explained, this is third party code and does not follow our CGL. If we change the code (even whitespace or other formatting things) it would be very hard to compare a next version with our version. I think we should keep third party software in their original state as much as possible (except for functional issues needed to integrate it). -
Simon Schaufelberger commented on patch set 1 12/12/11, 06:56
@Oli, ok i see your concerns. Look at this file for example: https://review.typo3.org/#patch,sidebyside,6902,1,typo3/contrib/swiftmailer/classes/Swift/Mime/Header.php looks like the white space was removed on our side since nothing else has changed. -
Simon Schaufelberger commented on patch set 1 12/12/11, 06:56
Oli, this is third party software and i am not responsible for their whitespaces. who cares about them? -
Simon Schaufelberger commented on patch set 1 12/12/11, 06:56
ok, shall i make another patch set and update the commit message? -
Oliver Klee commented on patch set 4 12/12/11, 06:56
Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 4 12/12/11, 06:56
Verified; Looks good to me, but someone else must approve No code changes, only submodule troubles... -
Simon Schaufelberger uploaded patch set 4 12/12/11, 06:56
-
Mr. Jenkins commented on patch set 1 12/12/11, 06:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2493/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/12/11, 06:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2714/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/12/11, 06:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2715/ : SUCCESS -
Steffen Ritter commented on patch set 4 V 0 12/12/11, 06:56
by team member; Looks good to me, approved -
Steffen Ritter merged patch set 4 12/12/11, 06:56