Review main Merged

69021[TASK] Slim down TBE_EDITOR

Andreas Kienast CR +2 V +2 Normal +0 −124 updated 05/05/21, 16:07

Commit message

TBE_EDITOR is a precursor of the current FormEngine with a lot of unused
legacy code. Most of its functions were used in an internal scope and
were not meant to be public API, thus everything that has no use at the
current time of writing this commit has been removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Andreas Kienast uploaded patch set 1 05/04/21, 20:21

  2. core-ci voted on patch set 1 V +1 05/04/21, 20:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11162

  3. Andreas Kienast uploaded patch set 2 05/04/21, 20:32

  4. Andreas Kienast uploaded patch set 3 05/04/21, 20:42

  5. core-ci voted on patch set 2 V +1 05/04/21, 20:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11164

  6. core-ci voted on patch set 3 V +1 05/04/21, 20:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11166

  7. Oliver Hader voted on patch set 3 CR +1 05/04/21, 21:11

  8. Christian Kuhn voted on patch set 3 CR +1 05/04/21, 21:18

  9. Christian Kuhn voted on patch set 3 V +1 05/05/21, 09:22

  10. Benni Mack voted on patch set 3 V +1 CR +1 05/05/21, 15:19

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 05/05/21, 16:07

  12. Christian Kuhn merged patch set 4 05/05/21, 16:07