Review main Merged

69023[TASK] Align configuration module search bar

Oli Bartsch CR +2 V +2 Normal +61 −34 updated 05/11/21, 16:57

Commit message

As a follow up of #94042, the search bar in
the configuration module is now also aligned
with the rest of the backend. The regular
expression checkbox is therefore moved into
a dropdown, according to the recordlist.

Since browsers nowadays add their own clearable
functionality to type=search fields, it's sufficient
to just register an event for it. Especially because
initialization of our custom clearable functionality
would otherwise lead to duplicated clear icons.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 813

  1. Oli Bartsch uploaded patch set 1 05/04/21, 20:43

  2. Oli Bartsch updated the commit message in patch set 2 05/04/21, 20:54

  3. core-ci voted on patch set 1 V -1 05/04/21, 20:56 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11167

  4. core-ci voted on patch set 2 V -1 05/04/21, 21:07 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11169

  5. Oli Bartsch uploaded patch set 3 05/04/21, 21:56

  6. core-ci voted on patch set 3 V -1 05/04/21, 22:06 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11180

  7. Oli Bartsch uploaded patch set 4 05/10/21, 11:39

  8. Oli Bartsch uploaded patch set 5 05/10/21, 11:47

  9. core-ci voted on patch set 4 V -1 05/10/21, 11:50 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11337

  10. core-ci voted on patch set 5 V +1 05/10/21, 11:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11338

  11. Christian Kuhn voted on patch set 5 V +1 CR +1 05/11/21, 12:36

  12. Daniel Goerz voted on patch set 5 V +2 CR +2 05/11/21, 16:56

  13. Daniel Goerz merged patch set 6 05/11/21, 16:57