Review main Abandoned

69025[FEATURE] Introduce f:condition.isInstanceOf view-helper

Oliver Hader CR 0 V 0 Normal +130 −0 updated 05/05/21, 14:58

Commit message

```
<f:condition.isInstanceOf
    value="{value}"
    class="\Vendor\Extension\SpecificModel">
    <f:then>Yepp, that is a SpecificModel</f:then>
</f:condition.isInstanceOf>
```

This view-helper implementation has been taken from
https://viewhelpers.fluidtypo3.org/fluidtypo3/vhs/2.1.2/Condition/Type/IsInstanceOf.html

@todo
+ add feature RST

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 56

  1. Oliver Hader uploaded patch set 1 05/04/21, 21:03

  2. Christian Kuhn commented on patch set 1 05/04/21, 21:15

    I'd prefer to move this to dashboard and mark internal since we need it only over there ... an instanceof VH is kinda smelly, don't you think?
  3. core-ci voted on patch set 1 V +1 05/04/21, 21:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11174

  4. Oliver Hader commented on patch set 1 CR -1 05/04/21, 21:43

    Probably move to dashboard extension, since it's currently required there only
  5. Oli Bartsch commented on patch set 1 05/05/21, 08:30

    Reply

    Let’s also make this internal. As you mention, it’s only needed for the dashboard and should IMO not become public API.
  6. Oliver Hader abandoned the change 05/05/21, 14:58

    Just realized it can be done much simpler...