Review main Abandoned

69029[WIP][FEATURE] Generate and use ActiveExtensions class

Jochen Roth CR 0 V 0 Hard +534 −46 updated 09/12/21, 18:14

Commit message

What it does:
* Generate ActiveExtensions.php (composer dump-autoload or when PackageManager writes PackageStates.php)
 * ComposerMode will store the ActiveExtensions.php in vendor/typo3/ActiveExtensions.php
 * Non-Composer will store the ActiveExtensions.php in typo3conf/
* Replaces the usage of PackageManager in ExtensionManagementUtility.php with the new ActiveExtensions
* Loads the class globally using the ClassLoader
* Remove enable/disable button in composer mode

Review

  • Code review CR 0
  • Verified V 0

Files 8

Review log 69

  1. Jochen Roth uploaded patch set 1 05/05/21, 09:41

  2. core-ci voted on patch set 1 V -1 05/05/21, 09:44 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11192

  3. Jochen Roth uploaded patch set 2 05/05/21, 14:20

  4. core-ci voted on patch set 2 V -1 05/05/21, 14:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11216

  5. Jochen Roth uploaded patch set 3 05/05/21, 14:46

  6. core-ci voted on patch set 3 V -1 05/05/21, 14:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11220

  7. Benjamin Franzke commented on patch set 3 CR -1 05/06/21, 09:45

    PackageFileCreator.php:34 Unresolved

    If we now parse /composer/installed.json anyway (which I think is cool, as it has everything we need, but as I've written before, I'm not sure we can use this as API), then I don't get why we still need to generate a global and *static* class. It has the major drawback that only *one* such class can exist in one process. That means: Once we integrate composer into the backend, we won't be able to generate and use a new autoloader and the new ActiveExtensions class. If we decide to use composer/installed.json, then please let's parse it in PackageManager, and cache it away. And for classic mode? PackageManager can fallback to reading composer.json files for classic mode.
  8. Benni Mack commented on patch set 3 09/02/21, 09:52

    Unresolved

    I think this is now obsolete.
  9. Jochen Roth abandoned the change 09/12/21, 18:14

    This is now obsolete