69031[BUGFIX] Return correct source record for relations
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
-
Verified V +2 Done
- Oliver Hader +2
- core-ci +1 CI
Issues 1
Files 20
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php1+15 −15
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizeParentContentChainLanguageSynchronizationSource.csv+36 −36
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_hotel.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_offer.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_price.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_hotel.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_offer.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_price.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel_offer_rel.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_offer.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_price.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel_offer_rel.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_offer.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_hotel.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_offer.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_price.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel_rel.php+1 −0
Review log 811
-
Oliver Hader uploaded patch set 1 05/05/21, 10:39
-
Oliver Hader uploaded patch set 2 05/05/21, 10:40
-
core-ci voted on patch set 2 V -1 05/05/21, 11:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11198
-
core-ci voted on patch set 1 V -1 05/05/21, 11:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11197
-
Oliver Hader commented on patch set 2 CR -1 05/05/21, 11:15
Hm... -
Oliver Hader commented on patch set 2 05/05/21, 11:25
DataMapProcessor.php:1022UnresolvedInteresting... the failure stems from string numbers being in that array... -
Oliver Hader commented on patch set 2 05/05/21, 11:46
Alright... * missing in 9.5: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64016/3/typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php#1165 * which would rely another missing change in 9.5: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58048/7/typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php -
Oliver Hader uploaded patch set 3 05/05/21, 11:47
-
core-ci voted on patch set 3 V +1 05/05/21, 12:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11202
-
Oliver Hader voted on patch set 3 V +2 CR +2 05/05/21, 13:34
-
Oliver Hader merged patch set 4 05/05/21, 13:34