Review 9.5 Merged

69031[BUGFIX] Return correct source record for relations

Oliver Hader CR +2 V +2 Normal +69 −51 updated 05/05/21, 13:34

Commit message

This change addresses a flaw when resolving ancestor ids of 1:n
relationships - resolving `l10n_source` pointer always was `0`.

Besides that now only non-empty `l10n_parent` or `l10n_source` are
returned as integer. Otherwise `null` is returned and signals that
a corresponding ancestor could not be resolved at all.

Scenario `localizeParentContentChainLanguageSynchronizationSource` of
`DataHandling\IRRE\ForeignField\Modify\ActionTest` was given already,
however `l10n_source` fields were missing in their TCA.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 20

Review log 811

  1. Oliver Hader uploaded patch set 1 05/05/21, 10:39

  2. Oliver Hader uploaded patch set 2 05/05/21, 10:40

  3. core-ci voted on patch set 2 V -1 05/05/21, 11:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11198

  4. core-ci voted on patch set 1 V -1 05/05/21, 11:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11197

  5. Oliver Hader commented on patch set 2 CR -1 05/05/21, 11:15

    Hm...
  6. Oliver Hader commented on patch set 2 05/05/21, 11:25

    DataMapProcessor.php:1022 Unresolved

    Interesting... the failure stems from string numbers being in that array...
  7. Oliver Hader uploaded patch set 3 05/05/21, 11:47

  8. core-ci voted on patch set 3 V +1 05/05/21, 12:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11202

  9. Oliver Hader voted on patch set 3 V +2 CR +2 05/05/21, 13:34

  10. Oliver Hader merged patch set 4 05/05/21, 13:34