Review 9.5 Merged

69033[TASK] Prevent superfluous filters in DataMapProcessor

Oliver Hader CR +2 V +2 Easy +9 −12 updated 05/05/21, 12:45

Commit message

For consistency in the filterNumericIds method of DataMapProcessor,
there should only be one result be returned. This patch removes the
second parameter to invert the methods behaviour.

Back-porting to TYPO3 v9.5 as well, for code consistency.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oliver Hader uploaded patch set 1 05/05/21, 11:47

  2. core-ci voted on patch set 1 V +1 05/05/21, 12:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11203

  3. Oliver Hader voted on patch set 1 V +2 CR +2 05/05/21, 12:45

  4. Oliver Hader merged patch set 2 05/05/21, 12:45